From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612AbdBIU2z (ORCPT ); Thu, 9 Feb 2017 15:28:55 -0500 Received: from mail-cys01nam02on0083.outbound.protection.outlook.com ([104.47.37.83]:11428 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932282AbdBIU2v (ORCPT ); Thu, 9 Feb 2017 15:28:51 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Nehal-bakulchandra.Shah@amd.com; From: Shah Nehal-Bakulchandra To: , , CC: , , , , , Shah Nehal-Bakulchandra , Shah Nehal-Bakulchandra , Suravee Suthikulpanit Subject: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled Date: Fri, 10 Feb 2017 01:20:51 +0530 Message-ID: <1486669851-25632-1-git-send-email-Nehal-Bakulchandra.Shah@amd.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.56.249.162] X-ClientProxiedBy: PN1PR01CA0042.INDPRD01.PROD.OUTLOOK.COM (10.164.136.142) To CY4PR12MB1350.namprd12.prod.outlook.com (10.168.169.7) X-MS-Office365-Filtering-Correlation-Id: a3c0ddb5-64cd-42bc-eacd-08d451252000 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:CY4PR12MB1350; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1350;3:RIq9c79eJFZ6nnVS8EMmi86f6jPOp/5IyP1bNdluM9VhThNrLHw1SioluoExVDriFf+aq5UkKAct/yHFirtFEhYtWHYI2iG95Sj8uSr38RlpFQl6Kiaf8ZPw5qnpkqhZjQ+PWgkiyYuSZgD5qL0jFXFlFR0I/luSJIL1CwDquE7g0LrBjS46MwRqyDsDfWCi42QuWl7z0xnTm+9EbrqnPtcAPq8750uWnh84m5LtCWqKMa+8gGUGoXpqJaguvDEsbUE5f9sqQCTHqp34ub/Atcc0zI7NMqX80DZJ7bFESj0=;25:VEO73fUQ9xKvi70Kydo6BcPQQmKjth/5DJytCZeVBRlISvOkywVf9hxuj/tGGruXFlPiStU0sm3pkxsM/oTkGAP881sPIpbnRKR3/wl8kQEbxptmnOgIjT1uECt5TG7QYuaDgnetfckTgdnWUvhfQfkTWuZcq+9zUJUYLHycb5tD5HDF88535fIUAf/iXbZaictW3mSR/w7aC+aNvYL540Un9IJK1c0qGVaAVHZzLaNXfyu28RwzqAbDODWuhaNC5LsrsxoCNF87azS2DjacxPSrShOS0h1iu2XXq2WI9qYboehM3/Ce/jUzoiIfUoZeViHIBZrNodgElkWSU8mtaEOifym3VO6QrxbDA874d7SfVlVoHvlH3ACPZgAuI7O4M78iEngragG3e0cezvceHCZbVigAS8b0jyR7OGOTveWgoYBjCO28BcrowdXmkPyUIHBZHMx6hebpMSB8KOdg8Q== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1350;31:sEdsc+hZwTQwkiE61eTYU+b6T84xsARla413ORqI0zRhj6eu/ucOP7t5hjWzcDuPhlhUXolZzOfaVbTd7clp5T8P7pu4m3lbilQai1GfrWL2q55DcGNEQxzkd49GInbcmTwqL4WEkB3Apl0MkhqIWetUiyir3SYc+ppEixQv/xwRJnbmhLuah01A2+P8vyLcpRArW7NyaEQeUlKKpiUpuiGTV+DGW/7YHCnKi+7Tl3I/jzcRY5oPxkP1fRjiKR2B;20:I04yetyQx4K1hL1SQ8JgHk+LuYJjfLqOGV+rAejQviFIjiK2QWHGY3l8RzwggbvfiJ5csLhUXaojw5pyMQSt44OMxlsEpJm6CHFgZTwBTKOzqqe5mbSNk7rZ3uVJva/jvW9Gwn+gHqYN6a2v/byJxXj7aJmgFYCp1MxdEdWL1p3C48ZeHX2nknk2jM7xFfIkON8XKWyv2ZWPREuMOMe9nu398nWGc4ecPXek7PT2lvgRdLTGiMi6p8L34n+hI3qxPSwarJYoxrlE7Bgbpc5Yq5I+XEAPtZhfODi23I7DLrXqmRIUtGg5QkiaEWILHlejhwFgekmpefxJxFgN8LPf8qDCE0pXtEmTyWn1TaeAJQ8hWjlTHYpHkzKa/4Y3NSRTa9jTP/BKHl9WllCa/uOHrxW5HFyEV+MKO1D9Ej3kQrsQKR2G0T7gNbpaKK9QjQCVkbxnjlCMymI8T437eHJNVDSG26+RGzzGFPcaRM9zoGYU8IGue6kOYvhrwXso3seO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(20161123558025)(6072148);SRVR:CY4PR12MB1350;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1350; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1350;4:MkHEjfM6J5t/sznknPbIPw2ULvRzdeepo/jQm0Fk9UcJsCUElINdeogUsq5NbMnDESruHpn31l9oGAPmRVRqIeOVbRbtC1n69c8e9bocS/xtto6Z96nVZAJBPyikCiOabOS6O6numzbdHOWllUue4yQHnByquji+CrApo8vfPX5sGYeR9wAizImgfUoiS2X50xN+604Aa9LxrX3/CJ8XQubJpRjbUO902ChkEdzrF+9eH2K+rFdo9ZSD9xM+PZXKzXgoJOCpazt0Qfa0wQMwMbsQA17L50v78d5WMyoedFOx81iuHd6xBphlczBprx2Cge2sq8S0o6e+lcS/snOFE+8uqrhDo0nkJ2lXXPCgnIVZCShm8epy+WWXwd0D4epGhM1Ml13xPcM9gjNoTZ83Iv0N11J8FF8cpEKNoCN85rqlR70hc927PNBFBpd+B9ZFhD04rlVXcWC0S25UiYHau6MUGMJdTr6oSidMI1HK5bk/zuhWfqYOhrzUwb6ZHuCziDeHowloUYnZdz4p/8ICsHu3tqiF1mTJGZsPbvgKcUS6mIuDVZgQQeCo2FihfNcYqGft2FBaI7tbYJ2JgKijFfwVgOCB4T+yjFzqvekbmI6tPYtJGD0eAkdLzb7EPU/rAJhpevbcugCR3Dyazf1L1Y40R8f7h37dErYmsSBvERI= X-Forefront-PRVS: 02135EB356 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39840400002)(39450400003)(39860400002)(39850400002)(39410400002)(189002)(199003)(50226002)(15650500001)(38730400002)(5003940100001)(97736004)(42186005)(5660300001)(101416001)(6666003)(54906002)(50986999)(25786008)(305945005)(47776003)(189998001)(7736002)(53936002)(53416004)(36756003)(68736007)(6486002)(4326007)(50466002)(81156014)(575784001)(86362001)(8676002)(2201001)(92566002)(66066001)(48376002)(3846002)(2906002)(106356001)(105586002)(6116002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1350;H:andbang4.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR12MB1350;23:fb3ktZvu0pnVliS0VCvCXUEVloS/gEoSeHn+KUNXH?= =?us-ascii?Q?eKP1aFb8G7TMMINf1exaqFgNhyKcsdffG+vSBKJhAU16ByLSbegCV405eFxv?= =?us-ascii?Q?NjhYV4O0Q2N7/ipijxqRjG0eu6z2NCjg7rHyhy4Q3y5rXhq9aH/oZAc8vREF?= =?us-ascii?Q?fBfnnZ2rR5HH2ce1awpdJkxx1Kvd6ySY0I0gapisBhB/T+NWVjKsPQ+yr100?= =?us-ascii?Q?yfYhIjoTuYKFZ5Tu7t2d0HIk5epspBGhRIMRI4ZGw3CUTRCPilc8VviB3SbY?= =?us-ascii?Q?uyJ28G3YCUopZw6qF1zIZDyyGzEZWcGfiBaOfseqeLRQVc1oSBAdZLRJlEGy?= =?us-ascii?Q?TJkufM4BNFM9hVxtJ5n618RD/tSgQ426/jyLrLroBF5J+Cd222t9C0SFNdXu?= =?us-ascii?Q?UoQMHWz0sBXvRiAETklDnR03nD7QmdFfUlHVAsxtJRDxpC6+Bo/acD1frf/i?= =?us-ascii?Q?64AAcigRNoyhPbqfIo6N5z2hyUukY8mKfb9k8D0QyH1sA40zYBGUTUSNl8L7?= =?us-ascii?Q?GWaSdKhXXnieTAmQEJfjNGS/IZzhVuFZcqRNVMf9viFoFaNF9kT28jTdJ1RE?= =?us-ascii?Q?SH3LeC8ywINR68KsxRijcqPFPMZ5Mu07m1ttlhRq0YZBibVDGe7gikAui3TM?= =?us-ascii?Q?mMX1C37z5mAi6J+yx+E3w6hGhvWgdqnh0/xuZqiYJWdgSnFFFKlcDblLOpDH?= =?us-ascii?Q?wZWs7qtgOiD0dou4Mf126Ji7feImeh3UaOqCAmnqaBp5aD2wHHtFq7Cm11Gz?= =?us-ascii?Q?TBXg1jJRyPnYqAXVO79b0UsZJeJH5P0TvJ5+fOrUKzZx0V/lUOvO4SKjL/0O?= =?us-ascii?Q?2tydMm0D65SoVbraPVx92zeTv2XghL7VyDllEu0c6bXyvCuvBthyUX8500tY?= =?us-ascii?Q?4QV6KstMbAle4MtWhWOTMjkSku81kYL3jqnXPuOIOrmEhxHtWuU222DkKvFe?= =?us-ascii?Q?FLJkcoW8vj498pnxDjvGFF5sYrBfrBbZehr7uKU+up9mR0B7HStuIlkEDatw?= =?us-ascii?Q?Sacv20FzzIgc8RdraGJvrnAc6351vXN1gYpiEaVxKknCi1mNVYyjsRCfkkpH?= =?us-ascii?Q?Jv38ajlbuVj8V7m3ciE9FC30C395/wrLQiD8LsdkbIanXdcms4iz7nKq0Z9D?= =?us-ascii?Q?TOHNVrzC4zCEX/NCzp95D6HJw6LiltySjVORLO+tvJUgRuuPC9fEA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1350;6:lVAO4M8b+jhTmWXxiyfopQJL5dQvNCgqV2dIafcYTSZi+wF0fF8zzkJEGto8u6qxQydE0c21WYewgiCnc0Kmh0tcMKKeRxlTIfCZcj/MVjuMh+MQCmXEs7vsbho4GuZxdaYxmhbedq8X6ai81UdS22q5/RrDeozt+CEY1Lh7oNqs0zcV0q2wtjwZr8QowP3oem7hC8bqlwvenWn+IDYdNwhVhcdz2sXDT2f5C7e+lJfEtTMD8ZXF5AedJNeKzDkYrQCMLxHYDKIZ+VhdfksQFXbaDpY7Rt9aXgdqF6/lRrdU4XbIE2xjD/kZBGDh2Zc4Q8EBYZk+p1PnIertnnyJtop1cJh9J2+0mq73y+1t5Q2J591RLVoqnoMKqwzzlobnU6OYhc3tjwa5WrwMToCo9XkbC5bYROJ/MhP2j17a93M=;5:Tz06gyPN0s3/USPaQ5qWkCx+I47RZDwj5e5X1OMDUGxtpV9KHqhxrdN8xUB5Ntur2aksHZWVUSJgB9T16kbeqq/20D5omKdrMqp9EQjiGvx5Q6iQpwBU6a5S6cWF11MWkgZuKkTHKjntxUz/GSx5gA==;24:9+EJIu5Cg057/fx/EXPQ1KijPt1JQMpLKfGbBj0ZBq8Xzhbom0WtJcSncrL+F4wbYv3hdvqtUJdbGP24s6ViX0vtreqI7yq6o4emyAl+9qI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1350;7:gxC8E+hx2M5K3nNn4cijwPkL8q81UWlDH4Njx3yt2UKkgRawqLT7vtBKIEynYlMPOut/5QojY3/9WRURP/+Qge80XgItbEGy0mcFgK1JvJ7gazFZJlSGcr9DEqYmS4OtoneS+r0BDBbaQ7jR5jreg02LLoBylGTJvgmLbmlvDYGjRj99QhhWIc38qviraLmYK7bsPtymFL2LzPnt5Wtzqwewyo3UxySPtyljP2APW4g4XcvbQZ5+DbG6j8fojQfKT2mPWFD7hvZ7uDGcE0KjPe8MLpnuopAbPeMH66H97w/6zd+dQa1GPojumh/ezDAhM+tD9JejaBHjIMN1TZDr9GLsb0//xLNHvHZbMpZLuDA6ybDvob2SqwSeRHtwvLx32BqkKFOgjugcl0sN7xn6z2zC/an6waWsUR3JnB5zSuNhtOAfKrUcc7wMgF5aT9LTp5jNyHEGHHFo0F8xKOvSzpqKpme0McD7p3hKpEIc7OKpdDWVnshXi01Pzv4Jq5F145y+qLUFhk4bUOusu3vzbg==;20:Lw3X1I8oiWuZ1LtH3ERsOBHI71cQFJLnNxassdm7+h/IXNcSU6/3dm8iN7hMrWlpIfAMQ3IkaTYh1nE37LPGN31YguskPEG8qYWdL+5p9u4WTOY34aCclYYTDGyzpod81ttpHKbAX0ilRUhtPfeSxXm5chb15H6qweF2JjPPAP2iMJ8xd4oqXhfd5ytk+rTKXKijXtUU6hRJ6b+pwa+rP5+jgaU5LMwzWeaVJgeUA0cQpIXdZOGl+XjfnRdPh/0X X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2017 19:51:57.3652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1350 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit causes a regression when dynamic TAR update is disabled: commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3 ("i2c: designware: detect when dynamic tar update is possible") In such case, the DW_IC_CON_10BITADDR_MASTER is R/W, and is changed by the logic that's trying to detect dynamic TAR update.The original value of DW_IC_CON_10BITADDR_MASTER bit should be restored. Signed-off-by: Shah Nehal-Bakulchandra Signed-off-by: Suravee Suthikulpanit --- drivers/i2c/busses/i2c-designware-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c index 6d81c56..0c57166 100644 --- a/drivers/i2c/busses/i2c-designware-core.c +++ b/drivers/i2c/busses/i2c-designware-core.c @@ -987,6 +987,11 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) (reg & DW_IC_CON_10BITADDR_MASTER)) { dev->dynamic_tar_update_enabled = true; dev_dbg(dev->dev, "Dynamic TAR update enabled"); + } else { + /* If test is failed then restore the original value */ + dev->dynamic_tar_update_enabled = false; + dev_dbg(dev->dev, "Dynamic TAR update disable restore the value"); + dw_writel(dev, reg, DW_IC_CON); } i2c_dw_release_lock(dev); -- 1.9.1