From: Byungchul Park <byungchul.park@lge.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, tkhai@yandex.ru
Subject: [PATCH] sched/deadline: Remove redundant code replenishing runtime
Date: Fri, 10 Feb 2017 18:11:28 +0900 [thread overview]
Message-ID: <1486717888-30580-1-git-send-email-byungchul.park@lge.com> (raw)
For a task passing its deadline while !rq, it will be replenished
in the following path because dl_se->deadline < rq_lock.
enqueue_dl_entity(ENQUEUE_WAKEUP)
update_dl_entity
Therefore, code replenishing it in the timer callback in the case is
unnecessary. This is not for enhancing performance but just for removing
a redundant code.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
kernel/sched/deadline.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 27737f3..9c77696 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -624,10 +624,8 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
* We can be both throttled and !queued. Replenish the counter
* but do not enqueue -- wait for our wakeup to do that.
*/
- if (!task_on_rq_queued(p)) {
- replenish_dl_entity(dl_se, dl_se);
+ if (!task_on_rq_queued(p))
goto unlock;
- }
#ifdef CONFIG_SMP
if (unlikely(!rq->online)) {
--
1.9.1
next reply other threads:[~2017-02-10 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 9:11 Byungchul Park [this message]
2017-02-10 13:39 ` Juri Lelli
2017-02-13 2:30 ` Byungchul Park
2017-02-13 4:29 ` Byungchul Park
2017-02-13 15:24 ` Juri Lelli
2017-02-13 23:42 ` Byungchul Park
2017-02-14 2:06 ` Byungchul Park
2017-02-14 10:54 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486717888-30580-1-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®