From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdBJSuY (ORCPT ); Fri, 10 Feb 2017 13:50:24 -0500 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:42117 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752380AbdBJSuT (ORCPT ); Fri, 10 Feb 2017 13:50:19 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2525:2553:2560:2563:2682:2685:2828:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3871:3872:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:7903:9025:10004:10400:10848:11232:11658:11914:12043:12679:12740:12760:12895:13069:13095:13161:13229:13311:13357:13439:14096:14097:14181:14659:14721:21067:21080:21433:21434:30045:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: balls28_59bd26b09f24c X-Filterd-Recvd-Size: 1727 Message-ID: <1486752614.2192.11.camel@perches.com> Subject: Re: [PATCH] compiler/compiler-gcc: Add __fallthrough From: Joe Perches To: Arnaldo Carvalho de Melo Cc: Christopher Li , Andrew Morton , linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org Date: Fri, 10 Feb 2017 10:50:14 -0800 In-Reply-To: <20170210171833.GB14313@kernel.org> References: <20170210144238.GC15066@kernel.org> <791a2621851fc989bc04dfe975ec29de15cbb557.1486746344.git.joe@perches.com> <20170210171833.GB14313@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-10 at 14:18 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 10, 2017 at 09:08:35AM -0800, Joe Perches escreveu: > > gcc v7.0 can warn on missing break statements from case labels > > using a special __attribute__((fallthrough))__ marker. > > > > Add a __fallthrough convenience macro for gcc versions >= 7 and > > make the generic use of __fallthrough a no-op. > > Can you state in the log message were this idea came from? Say, > something like: > > "This was introduced in the tools/include/linux/compiler.h, where it was > first noticed while buildint tools/perf/ in a Fedora Rawhide > environment." The request is from at least 2002. Maybe Andrew could add a link like: Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652 if he applies it.