From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbdBMIPd (ORCPT ); Mon, 13 Feb 2017 03:15:33 -0500 Received: from www.osadl.org ([62.245.132.105]:43721 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbdBMIPc (ORCPT ); Mon, 13 Feb 2017 03:15:32 -0500 From: Nicholas Mc Guire To: Cyrille Pitchen Cc: Marek Vasut , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Mika Westerberg , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Date: Mon, 13 Feb 2017 09:14:21 +0100 Message-Id: <1486973661-1164-1-git-send-email-der.herr@hofr.at> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes a sparse warning about incorrect type in retrun expression Signed-off-by: Nicholas Mc Guire --- V2: fixed prefix and the truncated commit message noted by Boris Brezillon - thanks! sparse complained about: drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces) drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi * drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] *base Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y) Patch is against 4.10-rc7 (localversion-next is next-20170213) drivers/mtd/spi-nor/intel-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c index 2956f2c..1a6de4b 100644 --- a/drivers/mtd/spi-nor/intel-spi.c +++ b/drivers/mtd/spi-nor/intel-spi.c @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev, ispi->base = devm_ioremap_resource(dev, mem); if (IS_ERR(ispi->base)) - return ispi->base; + return ERR_CAST(ispi->base); ispi->dev = dev; ispi->info = info; -- 2.1.4