From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752684AbdBNH15 (ORCPT ); Tue, 14 Feb 2017 02:27:57 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:51778 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752242AbdBNH0x (ORCPT ); Tue, 14 Feb 2017 02:26:53 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com From: Byungchul Park To: peterz@infradead.org, mingo@kernel.org, neilb@suse.de, nab@linux-iscsi.org, viro@zeniv.linux.org.uk Cc: ying.huang@intel.com, oleg@redhat.com, shli@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/9] fput: Don't reinvent the wheel but use existing llist API Date: Tue, 14 Feb 2017 16:26:26 +0900 Message-Id: <1487057190-25191-6-git-send-email-byungchul.park@lge.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1487057190-25191-1-git-send-email-byungchul.park@lge.com> References: <1487057190-25191-1-git-send-email-byungchul.park@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- fs/file_table.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 6d982b5..3209da2 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -231,12 +231,10 @@ static void __fput(struct file *file) static void delayed_fput(struct work_struct *unused) { struct llist_node *node = llist_del_all(&delayed_fput_list); - struct llist_node *next; + struct file *f, *t; - for (; node; node = next) { - next = llist_next(node); - __fput(llist_entry(node, struct file, f_u.fu_llist)); - } + llist_for_each_entry_safe(f, t, node, f_u.fu_llist) + __fput(f); } static void ____fput(struct callback_head *work) @@ -310,7 +308,7 @@ void put_filp(struct file *file) } void __init files_init(void) -{ +{ filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); percpu_counter_init(&nr_files, 0, GFP_KERNEL); @@ -329,4 +327,4 @@ void __init files_maxfiles_init(void) n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10; files_stat.max_files = max_t(unsigned long, n, NR_FILE); -} +} -- 1.9.1