From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdBOObn (ORCPT ); Wed, 15 Feb 2017 09:31:43 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33168 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdBOObk (ORCPT ); Wed, 15 Feb 2017 09:31:40 -0500 From: Andrey Drobyshev To: linux-kernel@vger.kernel.org Cc: gq@cs.msu.su, giometti@enneenne.com Subject: [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event(). Date: Wed, 15 Feb 2017 17:31:05 +0300 Message-Id: <1487169069-15721-5-git-send-email-immortalguardian1@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1487169069-15721-1-git-send-email-immortalguardian1@gmail.com> References: <1487169069-15721-1-git-send-email-immortalguardian1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander GQ Gerasiov Otherwise we get "scheduling while atomic" problem. Signed-off-by: Alexander GQ Gerasiov --- drivers/pps/kapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c index 805c749..a9a111d 100644 --- a/drivers/pps/kapi.c +++ b/drivers/pps/kapi.c @@ -226,11 +226,11 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event, /* Wake up if captured something */ if (captured) { pps->last_ev++; + spin_unlock_irqrestore(&pps->lock, flags); wake_up_interruptible_all(&pps->queue); - kill_fasync(&pps->async_queue, SIGIO, POLL_IN); - } - spin_unlock_irqrestore(&pps->lock, flags); + } else + spin_unlock_irqrestore(&pps->lock, flags); } EXPORT_SYMBOL(pps_event); -- 2.1.4