mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
To: <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Subject: [PATCH] tools/lib/api: allow the linker to be overridden
Date: Wed, 15 Feb 2017 15:56:30 +0100	[thread overview]
Message-ID: <1487170590-17970-1-git-send-email-marcin.nowakowski@imgtec.com> (raw)

Makefile in lib/api unconditionally sets the LD to support
cross-compilation. However, when invoked from within the perf build LD
may be already appropriately set for a given platform and the override
may lead to cross-compilation without appropriate linker flags.

Change the unconditional override to a conditional one.

Fixes: 37b4e2020a5f ('perf build: Add EXTRA_LDFLAGS option to makefile')
Fixes: 703e01652d25 ('tools lib api: Respect CROSS_COMPILE for the linker')

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
 tools/lib/api/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
index adba83b..42e00c4 100644
--- a/tools/lib/api/Makefile
+++ b/tools/lib/api/Makefile
@@ -10,7 +10,7 @@ endif
 
 CC = $(CROSS_COMPILE)gcc
 AR = $(CROSS_COMPILE)ar
-LD = $(CROSS_COMPILE)ld
+LD ?= $(CROSS_COMPILE)ld
 
 MAKEFLAGS += --no-print-directory
 
-- 
2.7.4

             reply	other threads:[~2017-02-15 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 14:56 Marcin Nowakowski [this message]
2017-02-15 15:18 ` Arnaldo Carvalho de Melo
2017-02-15 15:25   ` Marcin Nowakowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487170590-17970-1-git-send-email-marcin.nowakowski@imgtec.com \
    --to=marcin.nowakowski@imgtec.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®