From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754633AbdBPLeM (ORCPT ); Thu, 16 Feb 2017 06:34:12 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:57757 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbdBPLeK (ORCPT ); Thu, 16 Feb 2017 06:34:10 -0500 Message-ID: <1487244825.2377.39.camel@pengutronix.de> Subject: Re: [PATCH v4 17/36] media: Add userspace header file for i.MX From: Philipp Zabel To: Steve Longerbeam Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Steve Longerbeam Date: Thu, 16 Feb 2017 12:33:45 +0100 In-Reply-To: <1487211578-11360-18-git-send-email-steve_longerbeam@mentor.com> References: <1487211578-11360-1-git-send-email-steve_longerbeam@mentor.com> <1487211578-11360-18-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > --- > include/uapi/media/Kbuild | 1 + > include/uapi/media/imx.h | 29 +++++++++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 include/uapi/media/imx.h > > diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild > index aafaa5a..fa78958 100644 > --- a/include/uapi/media/Kbuild > +++ b/include/uapi/media/Kbuild > @@ -1 +1,2 @@ > # UAPI Header export list > +header-y += imx.h > diff --git a/include/uapi/media/imx.h b/include/uapi/media/imx.h > new file mode 100644 > index 0000000..1fdd1c1 > --- /dev/null > +++ b/include/uapi/media/imx.h > @@ -0,0 +1,29 @@ > +/* > + * Copyright (c) 2014-2015 Mentor Graphics Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version > + */ > + > +#ifndef __UAPI_MEDIA_IMX_H__ > +#define __UAPI_MEDIA_IMX_H__ > + > +/* > + * events from the subdevs > + */ > +#define V4L2_EVENT_IMX_CLASS V4L2_EVENT_PRIVATE_START > +#define V4L2_EVENT_IMX_NFB4EOF (V4L2_EVENT_IMX_CLASS + 1) > +#define V4L2_EVENT_IMX_FRAME_INTERVAL (V4L2_EVENT_IMX_CLASS + 2) These events are still i.MX specific. I think they shouldn't be. > +enum imx_ctrl_id { > + V4L2_CID_IMX_MOTION = (V4L2_CID_USER_IMX_BASE + 0), > + V4L2_CID_IMX_FIM_ENABLE, > + V4L2_CID_IMX_FIM_NUM, > + V4L2_CID_IMX_FIM_TOLERANCE_MIN, > + V4L2_CID_IMX_FIM_TOLERANCE_MAX, > + V4L2_CID_IMX_FIM_NUM_SKIP, > +}; > + > +#endif regards Philipp