From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932712AbdBPQJU (ORCPT ); Thu, 16 Feb 2017 11:09:20 -0500 Received: from smtp2.infineon.com ([217.10.52.18]:32861 "EHLO smtp2.infineon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932316AbdBPQJT (ORCPT ); Thu, 16 Feb 2017 11:09:19 -0500 X-SBRS: None From: Peter Huewe To: Jarkko Sakkinen CC: Jason Gunthorpe , , , , Christophe Ricard , "Peter Huewe" Subject: [PATCH 0/5] Fix whole native SPI TPM driver Date: Thu, 16 Feb 2017 16:08:21 +0000 Message-ID: <1487261306-2494-1-git-send-email-peter.huewe@infineon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.29.170.145] X-ClientProxiedBy: MUCSE601.infineon.com (172.23.7.102) To MUCSE612.infineon.com (172.23.7.113) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During our testing it showed that unfortunately the whole native spi tpm driver was more or less non-functional since it was merged, e.g. the wrong byte for waitstate handling was used and transfers larger than 64 bytes did not work at all. This was probably caused by the merging of the different approaches back then, as the initial RFC patch did not have these problems, and also my sudden lack of time/commitment back then. I'm sorry that the final driver code went untested for that long time. This patch set fixes these issues one by one. In order to avoid duplication the read/write function was consolidated to one transfer function, so we do not have to apply the same fix at two locations. Maybe consider squashing it - we splitted it for easier review. Affected Kernels: 4.8, 4.9, 4.10 Patchset was tested on Raspberry Pi2 with SLB9670 (TPM1.2 and TPM2.0) Peter Huewe (5): tpm_tis_spi: Use single function to transfer data tpm_tis_spi: Abort transfer when too many wait states are signaled tpm_tis_spi: Check correct byte for wait state indicator tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes tpm_tis_spi: Add small delay after last transfer drivers/char/tpm/tpm_tis_spi.c | 163 +++++++++++++++++------------------------ 1 file changed, 69 insertions(+), 94 deletions(-) -- 2.7.4