From: Phil Reid <preid@electromag.com.au>
To: thloh@altera.com, linus.walleij@linaro.org, gnurou@gmail.com,
preid@electromag.com.au, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high
Date: Fri, 17 Feb 2017 17:12:32 +0800 [thread overview]
Message-ID: <1487322752-31896-1-git-send-email-preid@electromag.com.au> (raw)
When a threaded irq handler is chained attached to one of the gpio
pins when configure for level irq the altera_gpio_irq_leveL_high_handler
does not mask the interrupt while being handled by the chained irq.
This resulting in the threaded irq not getting enough cycles to complete
quickly enough before the irq was disabled as faulty.
It looks like handle_level_irq should be used in this situation
instead of handle_simple_irq.
Signed-off-by: Phil Reid <preid@electromag.com.au>
---
drivers/gpio/gpio-altera.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index 5bddbd5..d67dcca 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -310,7 +310,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
altera_gc->interrupt_trigger = reg;
ret = gpiochip_irqchip_add(&altera_gc->mmchip.gc, &altera_irq_chip, 0,
- handle_simple_irq, IRQ_TYPE_NONE);
+ altera_gc->interrupt_trigger == IRQ_TYPE_LEVEL_HIGH ?
+ handle_level_irq : handle_simple_irq, IRQ_TYPE_NONE);
if (ret) {
dev_err(&pdev->dev, "could not add irqchip\n");
--
1.8.3.1
next reply other threads:[~2017-02-17 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 9:12 Phil Reid [this message]
2017-02-17 9:23 ` Andy Shevchenko
2017-02-17 11:32 ` Phil Reid
2017-02-17 11:40 ` Andy Shevchenko
2017-02-23 14:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487322752-31896-1-git-send-email-preid@electromag.com.au \
--to=preid@electromag.com.au \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®