mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Samuelson <peter@cadcamlab.org>
To: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org
Subject: beware of dead string constants
Date: Tue, 21 Nov 2000 06:02:35 -0600 (CST)	[thread overview]
Message-ID: <14874.25691.629724.306563@wire.cadcamlab.org> (raw)


While trying to clean up some code recently (CONFIG_MCA, hi Jeff), I
discovered that gcc 2.95.2 (i386) does not remove dead string
constants:

  void foo (void)
  {
    if (0)
      printk(KERN_INFO "bar");
  }

Annoyingly, gcc forgets to drop the "<6>bar\0".  It shows up in the
object file, needlessly clogging your cachelines.

This has ramifications for anyone thinking of converting #ifdefs to
if(){}, which is supposed to be the way of the future.  In my situation
I am trying to convert '#ifdef CONFIG_MCA' to 'if (MCA_bus)' where
MCA_bus is #defined to 0 on most architectures.

'static' variables in block scope, same story.

This is mostly a heads-up to say that in this regard gcc is not ready
for prime time, so we really can't get away with using if() as an ifdef
yet, at least not without penalty.

I've just asked gcc-help@gcc.gnu.org about this; if I hear anything
interesting I'll report back.

Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

             reply	other threads:[~2000-11-21 12:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-21 12:02 Peter Samuelson [this message]
2000-11-21 12:13 ` Jakub Jelinek
2000-11-21 12:24   ` Peter Samuelson
2000-11-21 20:51   ` J . A . Magallon
2000-11-22  1:14     ` Peter Samuelson
2000-11-22  8:27       ` Urban Widmark
2000-11-22 18:48 Michael Elizabeth Chastain
2000-11-23 13:06 ` Werner Almesberger
2000-11-23 23:29 Bernd Eckenfels
2000-11-23 23:39 ` Jeff Garzik
2000-11-24  3:36   ` Peter Samuelson
2000-11-24  4:15   ` Chris Wedgwood
2000-11-26 14:29 Bernd Eckenfels

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14874.25691.629724.306563@wire.cadcamlab.org \
    --to=peter@cadcamlab.org \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®