From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdBRVuz (ORCPT ); Sat, 18 Feb 2017 16:50:55 -0500 Received: from [160.91.203.10] ([160.91.203.10]:51102 "EHLO smtp1.ccs.ornl.gov" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751326AbdBRVu1 (ORCPT ); Sat, 18 Feb 2017 16:50:27 -0500 From: James Simmons To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin Cc: Linux Kernel Mailing List , Lustre Development List , Alex Zhuravlev , James Simmons Subject: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs Date: Sat, 18 Feb 2017 16:47:14 -0500 Message-Id: <1487454435-4895-14-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1487454435-4895-1-git-send-email-jsimmons@infradead.org> References: <1487454435-4895-1-git-send-email-jsimmons@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Zhuravlev on small filesystems plain log can grow dramatically. especially given large record sizes produced by DNE and extended chunksize. I saw >50% of space consumed by a single llog file which was still in use. this leads to test failures (sanityn, etc). the patch introduces additional limit on plain llog size, which is calculated as /64 (128MB at most) at llog creation time. Signed-off-by: Alex Zhuravlev Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838 Reviewed-on: https://review.whamcloud.com/18028 Reviewed-by: Andreas Dilger Reviewed-by: wangdi Reviewed-by: Mike Pershin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/llog.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/staging/lustre/lustre/obdclass/llog.c b/drivers/staging/lustre/lustre/obdclass/llog.c index 83c5b62..320ff6b 100644 --- a/drivers/staging/lustre/lustre/obdclass/llog.c +++ b/drivers/staging/lustre/lustre/obdclass/llog.c @@ -319,10 +319,26 @@ static int llog_process_thread(void *arg) * the case and re-read the current chunk * otherwise. */ + int records; + if (index > loghandle->lgh_last_idx) { rc = 0; goto out; } + /* <2 records means no more records + * if the last record we processed was + * the final one, then the underlying + * object might have been destroyed yet. + * we better don't access that.. + */ + mutex_lock(&loghandle->lgh_hdr_mutex); + records = loghandle->lgh_hdr->llh_count; + mutex_unlock(&loghandle->lgh_hdr_mutex); + if (records <= 1) { + rc = 0; + goto out; + } + CDEBUG(D_OTHER, "Re-read last llog buffer for new records, index %u, last %u\n", index, loghandle->lgh_last_idx); /* save offset inside buffer for the re-read */ -- 1.8.3.1