From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Lijun Ou <oulijun@huawei.com>
Cc: "Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Salil <salil.mehta@huawei.com>, Shaobo Xu <xushaobo2@huawei.com>,
Wei Yongjun <weiyj.lk@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/hns: include linux/module.h
Date: Sun, 19 Feb 2017 08:58:33 -0500 [thread overview]
Message-ID: <1487512713.86943.115.camel@redhat.com> (raw)
In-Reply-To: <20170217143945.2217431-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote:
> I ran into a build error on arm64 randconfig testing:
>
> infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to
> 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: parameter names
> (without types) in function declaration [-Werror]
> infiniband/hw/hns/hns_roce_main.c:979:226: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:979:226: error: type defaults to
> 'int' in declaration of 'module_init' [-Werror=implicit-int]
> infiniband/hw/hns/hns_roce_main.c:979:1: error: parameter names
> (without types) in function declaration [-Werror]
>
> Including the module.h makes it build again.
>
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-02-19 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 14:38 Arnd Bergmann
2017-02-19 13:58 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487512713.86943.115.camel@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@arndb.de \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=salil.mehta@huawei.com \
--cc=sean.hefty@intel.com \
--cc=weiyj.lk@gmail.com \
--cc=xavier.huwei@huawei.com \
--cc=xushaobo2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome