From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbdBTEpv (ORCPT ); Sun, 19 Feb 2017 23:45:51 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47740 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbdBTEpu (ORCPT ); Sun, 19 Feb 2017 23:45:50 -0500 X-ME-Sender: X-Sasl-enc: 33L+8ggbGU5K8qLp08V7C/0ZabIe+j10riWFCxXzNeZG 1487565948 Message-ID: <1487565939.3779.4.camel@aj.id.au> Subject: Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access From: Andrew Jeffery To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , Corey Minyard Cc: Joel Stanley , openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 20 Feb 2017 15:15:39 +1030 In-Reply-To: <36014e0c-82f8-eeaf-ee2a-6c1e413b957d@kaod.org> References: <20161206025715.2002-1-andrew@aj.id.au> <36014e0c-82f8-eeaf-ee2a-6c1e413b957d@kaod.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-tGVLQhebTuomVAgXPLur" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-tGVLQhebTuomVAgXPLur Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Cory, On Tue, 2016-12-06 at 16:02 +0100, C=C3=A9dric Le Goater wrote: > [ this is a resend bc of some mailing list issues]=C2=A0 >=20 > On 12/06/2016 03:57 AM, Andrew Jeffery wrote: > > The registers for the bt-bmc device live under the Aspeed LPC > > controller. Devicetree bindings have recently been introduced for the > > LPC controller where the "host" portion of the LPC register space is > > described as a syscon device. Future devicetrees describing the bt-bmc > > device should nest its node under the appropriate "simple-mfd", "syscon= " > > compatible node. > >=20 > > This change allows the bt-bmc driver to function with both syscon and > > non-syscon- based devicetree descriptions by always using a regmap for > > register access, either retrieved from the parent syscon device or > > instantiated if none exists. > >=20 > > The patch has been tested on an OpenPOWER Palmetto machine, successfull= y > > booting, rebooting and powering down the host. > >=20 > > Signed-off-by: Andrew Jeffery >=20 > It would be nice to have an example of the associated binding.=C2=A0 > I did not see it. A part from that : >=20 > Reviewed-by: C=C3=A9dric Le Goater Will this make it into 4.11? Cheers, Andrew --=-tGVLQhebTuomVAgXPLur Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYqnRzAAoJEJ0dnzgO5LT5mX0P/jo7B36oyELDJayFkMfGxY04 dEoI9LkP6KO0ojTHV5kO1WdUaCvnjg+3tBJM2fbE5/Wj77NFkrOd57c+USdjOfEp V+eujaij3TsGIJsi7Nh0p9Nbcls2x92dAJ8/gfPpk0VsLHDbCWLHFYqa6uIofCla ODMepsyY6G3DWe9C182pmUX9y80bsdCDJfmOJ576xvIoAna/d/wd58ZaaaKPp9dD yNTuSm6uwjOKdB6VIlCH5DrOhy4DM8dAJgJFTdBTUZ7E9dJ0k0+Kkud9BB0b+T4N tnGz1j2QVghYOTprg55ARmBg5K8C1j/TWMS4ZrjLe9rMdIk9pOqZUBF9qxpPUXaB DxU19fx1oYaYXXsi6sqUt5Y9wJk3pG7HtsEBHfgJaPwExTSEbKcLclMRVWOsBfqt BgYPFK+toWw0LzJ0/PH9Igw7SjQRb5aIj450GCiiJiVyPHUZOiGf17ZN7Xo/PXNY F9OEWt+mWtoiNwrTQ0XT6fTczrfcjhhjKs7JsWLepXZwxJ/mx4Zck37mbcdRcnTh wPA5K3U+DIR6qSDNgYrP4zMr55mcGKiipyZsXLVBhZsfidd0YMZe30MItjcTODxq LrHDFAAZdBe594DCNPfujlwHngvpIqLQcGBLw29klntVEmb0RXxZZltUatXt1WL4 fEBADPHKoxssEoU6wdpq =9GmV -----END PGP SIGNATURE----- --=-tGVLQhebTuomVAgXPLur--