From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-kernel@vger.kernel.org, Wenyou Yang <wenyou.yang@atmel.com>,
Josh Wu <rainyfeeling@outlook.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook
Date: Mon, 20 Feb 2017 13:28:38 +0100 [thread overview]
Message-ID: <1487593718-20752-4-git-send-email-boris.brezillon@free-electrons.com> (raw)
In-Reply-To: <1487593718-20752-1-git-send-email-boris.brezillon@free-electrons.com>
The last/only user of the chip->write_page() hook (the Atmel NAND
controller driver) has been reworked and is no longer specifying a custom
->write_page() implementation.
Drop this hook before someone else start abusing it.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/mtd/nand/nand_base.c | 10 ++++------
include/linux/mtd/nand.h | 4 ----
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index ec1c28aaaf23..c8894f31392e 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2839,9 +2839,10 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
/* We still need to erase leftover OOB data */
memset(chip->oob_poi, 0xff, mtd->oobsize);
}
- ret = chip->write_page(mtd, chip, column, bytes, wbuf,
- oob_required, page, cached,
- (ops->mode == MTD_OPS_RAW));
+
+ ret = nand_write_page(mtd, chip, column, bytes, wbuf,
+ oob_required, page, cached,
+ (ops->mode == MTD_OPS_RAW));
if (ret)
break;
@@ -4623,9 +4624,6 @@ int nand_scan_tail(struct mtd_info *mtd)
}
}
- if (!chip->write_page)
- chip->write_page = nand_write_page;
-
/*
* Check ECC mode, default to software if 3byte/512byte hardware ECC is
* selected and we have 256 byte pagesize fallback to software ECC
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index c5f3a012ae62..9d51dee53be4 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -818,7 +818,6 @@ nand_get_sdr_timings(const struct nand_data_interface *conf)
* @errstat: [OPTIONAL] hardware specific function to perform
* additional error status checks (determine if errors are
* correctable).
- * @write_page: [REPLACEABLE] High-level page write function
*/
struct nand_chip {
@@ -843,9 +842,6 @@ struct nand_chip {
int (*scan_bbt)(struct mtd_info *mtd);
int (*errstat)(struct mtd_info *mtd, struct nand_chip *this, int state,
int status, int page);
- int (*write_page)(struct mtd_info *mtd, struct nand_chip *chip,
- uint32_t offset, int data_len, const uint8_t *buf,
- int oob_required, int page, int cached, int raw);
int (*onfi_set_features)(struct mtd_info *mtd, struct nand_chip *chip,
int feature_addr, uint8_t *subfeature_para);
int (*onfi_get_features)(struct mtd_info *mtd, struct nand_chip *chip,
--
2.7.4
next prev parent reply other threads:[~2017-02-20 12:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 12:28 [PATCH v2 0/3] mtd: nand: Rework/cleanup the Atmel NAND driver Boris Brezillon
2017-02-20 12:28 ` [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon
2017-02-20 20:27 ` Andy Shevchenko
2017-02-20 20:38 ` Boris Brezillon
2017-02-20 20:50 ` Boris Brezillon
2017-02-20 23:40 ` Andy Shevchenko
2017-02-20 23:54 ` Andy Shevchenko
2017-02-21 8:06 ` Boris Brezillon
2017-02-21 10:03 ` Andy Shevchenko
2017-02-21 10:26 ` Boris Brezillon
2017-02-21 10:46 ` Nicolas Ferre
2017-02-21 11:02 ` Andy Shevchenko
2017-02-21 11:20 ` Boris Brezillon
2017-02-21 13:47 ` Nicolas Ferre
2017-02-21 15:55 ` Andy Shevchenko
2017-02-21 16:12 ` Alexandre Belloni
2017-02-21 11:27 ` Alexandre Belloni
2017-02-21 16:09 ` Andy Shevchenko
2017-02-21 16:21 ` Alexandre Belloni
2017-02-21 16:32 ` Andy Shevchenko
2017-02-21 16:43 ` Andy Shevchenko
2017-02-21 17:14 ` Alexandre Belloni
2017-02-24 5:18 ` Håvard Skinnemoen
2017-02-24 8:14 ` Hans-Christian Noren Egtvedt
2017-02-24 8:27 ` Boris Brezillon
2017-02-24 8:52 ` Hans-Christian Noren Egtvedt
2017-02-24 8:55 ` Boris Brezillon
2017-02-24 9:04 ` Hans-Christian Noren Egtvedt
2017-02-24 9:21 ` Boris Brezillon
2017-02-24 9:51 ` Alexandre Belloni
2017-02-24 11:43 ` Andy Shevchenko
2017-03-01 8:22 ` Boris Brezillon
2017-03-01 8:38 ` Hans-Christian Noren Egtvedt
2017-03-01 8:49 ` Boris Brezillon
2017-02-24 9:28 ` Alexandre Belloni
2017-02-21 17:05 ` Alexandre Belloni
2017-02-21 13:55 ` Russell King - ARM Linux
2017-02-21 13:02 ` Nicolas Ferre
2017-02-20 12:28 ` [PATCH v2 2/3] mtd: nand: atmel: Document the new DT bindings Boris Brezillon
2017-02-21 13:11 ` Nicolas Ferre
2017-02-27 19:12 ` Rob Herring
2017-02-20 12:28 ` Boris Brezillon [this message]
2017-03-07 12:04 ` [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Masahiro Yamada
2017-03-07 18:34 ` Boris Brezillon
2017-03-08 1:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487593718-20752-4-git-send-email-boris.brezillon@free-electrons.com \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=egtvedt@samfundet.no \
--cc=galak@codeaurora.org \
--cc=hskinnemoen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=rainyfeeling@outlook.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®