From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbdBTS6g (ORCPT ); Mon, 20 Feb 2017 13:58:36 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:34547 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdBTS6e (ORCPT ); Mon, 20 Feb 2017 13:58:34 -0500 X-AuditID: cbfec7f2-f790f6d000002555-62-58ab3c50917a From: Andrzej Hajda To: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski Subject: [PATCH] PM / OPP: fix off-by-one bug in dev_pm_opp_get_max_volt_latency loop Date: Mon, 20 Feb 2017 19:57:57 +0100 Message-id: <1487617077-21865-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsWy7djP87oBNqsjDA5dNLK4te4cq8XGGetZ LS7vmsNm8bn3CKPF2iN32S3e/DjLZHHm9CVWix9nulksNj84xubA6XG5r5fJY9OqTjaPLVfb WTz6tqxi9Dh+YzuTx+dNcgFsUVw2Kak5mWWpRfp2CVwZ2+a/Zi1Yw17RvHwbWwPjL9YuRk4O CQETiff7nrNA2GISF+6tZ+ti5OIQEljKKLGj/xw7hPOZUWJ3x0u4jtbVS6GqljFKtKzZDZYQ EvjPKPHndCqIzSagKfF3802wIhGB04wS976eZwRxmAV6GCXmXm9g7mLk4BAWCJfY+soepIFF QFXiwdxnjCA2r4CzxOYjIBtAtslJ3DzXyQzSKyHwmk2i5eJhRpBeCQFZiU0HmCFqXCR6f7cz QdjCEq+Ob2GHsGUkOjsOMkH0djNKfOo/wQ7hTGGU+PdhBlS3tcTh4xfBXmAW4JOYtG06M8QC XomONiGIEg+J05P/Q4UdJSZd9QExhQRiJd7ecJnAKL2AkWEVo0hqaXFuemqxsV5xYm5xaV66 XnJ+7iZGYBSf/nf80w7GryesDjEKcDAq8fDu+LEqQog1say4MvcQowQHs5IIb4Lc6ggh3pTE yqrUovz4otKc1OJDjNIcLErivHsWXAkXEkhPLEnNTk0tSC2CyTJxcEo1MPa9P7W5r3I/Rzev pfKDM8vVZG/4LOydetq+OvToH1m227/T/7c+ztLbK1rUO2NV+dV9Vlv3tWSeu1B+yPmP0YfC f3/Ee4REtvi/S7+47cT142c5Lbep/u+eKLs7t/DSHb8Xs9n7DBM6ug6dfKUe7hnTHCnM1/v6 SMSLOZNFc14dSVzqzPIh9KcSS3FGoqEWc1FxIgB2uwWZ3gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xq7pLbFZHGJxcxGVxa905VouNM9az WlzeNYfN4nPvEUaLtUfuslu8+XGWyeLM6UusFj/OdLNYbH5wjM2B0+NyXy+Tx6ZVnWweW662 s3j0bVnF6HH8xnYmj8+b5ALYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9 Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWsW3+a9aCNewVzcu3sTUw/mLtYuTkkBAwkWhdvZQN whaTuHBvPZDNxSEksIRRYvKEQ1BOI5PEp29bWECq2AQ0Jf5uvgmWEBE4zSixadI6ZhCHWaCP UaLx7yqgDAeHsEC4xNZX9iANLAKqEg/mPmMEsXkFnCU2H4FZJydx81wn8wRG7gWMDKsYRVJL i3PTc4sN9YoTc4tL89L1kvNzNzECg3fbsZ+bdzBe2hh8iFGAg1GJh3fHj1URQqyJZcWVuYcY JTiYlUR4E+RWRwjxpiRWVqUW5ccXleakFh9iNAVaPpFZSjQ5HxhZeSXxhiaG5paGRsYWFuZG RkrivCUfroQLCaQnlqRmp6YWpBbB9DFxcEo1MCbcDvrpvuOPrVRm7x7OgjcTGsXXBR+ZfEy8 Zp/nToftOnM2WD7PaL68N2iRyCoPtQvno0zFXvdqL7th2GpzP9BL4ASH5lmPOF2hT5k2y0Pa g21P3ptfx3hm+v2205mVXyV0jQ5/y2CSbVv9rbji5nEJtbIjPBxqhv6uyzkt8h9eXaT66eVt ayWW4oxEQy3mouJEAFUbYgN0AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170220185824eucas1p227fb1d8679f66825702296113c776095 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170220185824eucas1p227fb1d8679f66825702296113c776095 X-RootMTR: 20170220185824eucas1p227fb1d8679f66825702296113c776095 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reading array at given index before checking if index is valid results in illegal memory access. The bug was detected using KASAN framework. Signed-off-by: Andrzej Hajda --- drivers/base/power/opp/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index 91ec323..dae6172 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -231,7 +231,8 @@ unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev) * The caller needs to ensure that opp_table (and hence the regulator) * isn't freed, while we are executing this routine. */ - for (i = 0; reg = regulators[i], i < count; i++) { + for (i = 0; i < count; i++) { + reg = regulators[i]; ret = regulator_set_voltage_time(reg, uV[i].min, uV[i].max); if (ret > 0) latency_ns += ret * 1000; -- 2.7.4