From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754321AbdBVHvE (ORCPT ); Wed, 22 Feb 2017 02:51:04 -0500 Received: from mail-bl2nam02on0068.outbound.protection.outlook.com ([104.47.38.68]:52321 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754180AbdBVHu4 (ORCPT ); Wed, 22 Feb 2017 02:50:56 -0500 Authentication-Results: spf=pass (sender IP is 204.128.141.24) smtp.mailfrom=infinera.com; kroah.com; dkim=none (message not signed) header.d=none;kroah.com; dmarc=bestguesspass action=none header.from=infinera.com; From: Joakim Tjernlund To: "greg@kroah.com" CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] Correct function definition for C++ Thread-Topic: [PATCH 1/2] Correct function definition for C++ Thread-Index: AQHSjFaMuPJoCVccYkCF9+ON7YxfW6F1IuUAgAALRwA= Date: Wed, 22 Feb 2017 07:50:46 +0000 Message-ID: <1487749844.5760.17.camel@infinera.com> References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> <20170222071022.GA9186@kroah.com> In-Reply-To: <20170222071022.GA9186@kroah.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.100.99.93] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <1B461B268244464BAE5EBCF1E267BE05@infinera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:204.128.141.24;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39450400003)(39830400002)(2980300002)(438002)(377424004)(189002)(199003)(24454002)(50466002)(103116003)(53416004)(47776003)(54356999)(86362001)(76176999)(50986999)(2351001)(5660300001)(106116001)(6246003)(6116002)(36756003)(106466001)(102836003)(3846002)(38730400002)(4326007)(189998001)(110136004)(8746002)(229853002)(305945005)(2950100002)(2900100001)(6916009)(356003)(92566002)(8676002)(7736002)(7636002)(54906002)(2501003)(626004)(77096006)(8936002)(33646002)(23756003)(246002)(5640700003)(1730700003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR10MB0460;H:owa.infinera.com;FPR:;SPF:Pass;PTR:outgoingmail2.infinera.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2NAM03FT027;1:2TPvmN7up6d9G/ddnqaKTIYUQbZDpPJ28RE2NyRDw/VHD5h2YQk56/gNCZBLklXE5z/rrwWwtMQI3bUgaqXosm9oL8wGvhkH32/LJaPOQxTO2YHw7Da/ueFEqccM3Qzf58HPesFywmSXEvq8mm93Yy5xOUBITmOLQBg9yo24T31Ajm2nSWjYaGw4J2Xba/7uVK8J9D/qv/ggr1ASNDzc9EIq3OzW6gNEcv0JDcQH4hzb79gA0R7GPSRHbdHn0NP7mE0b5MXuV+GZ6TAdKnEyvdh0VJ5t5K7UnhPph1Uk4JSZcQyRAmCWmLzB03z5gIcXWi1LJ5h7HsGNsDnMn4iEZNCv80TW8weDg+kSQEjZq4nGcFXpagsebr9AdOUKGcj4SgCfNkhR5cva6UmW1DnDpleILyJmellaxVgxRN1jwvTe2tfYqDCvgG8LZOANL97zu1KPdj5JqY0EWaEty6wnF//sRJtcpUyo20xUqpSdtxMQcRF2U2XyJ3azu1mplLE5krNxIYDJ/XgoGJNAgSehQzmUswl/RCigFZpt8hXIFVY= X-MS-Office365-Filtering-Correlation-Id: 77217965-93d4-4e41-3714-08d45af78391 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:CY1PR10MB0460; X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0460;3:3eYX6JMJmaZ4WL8q5SWkg35rq2knmAnfEZlxmcnwC1Xrv2+dYq+Q1v8yIexpbHVqC0QU/gOUoqkX9ZGt7XwIFKNIC1PBlJd7zED0YuxvHGH74Bfni4E4ochXNvj3TA9c2c0NL8hh+EzjXGA0DkGzN15ctC1nCGfjChYsMJPhM1eI8ktRnI0weHutYqtytVfi/3h2cfvK8c5EU4okhSNjQ/Fz6yJCzFHQLiYeShd3Aw4mI1IpvYshUO3JeidXIRl+BHQ/7kTgFT437NTGATGQ8ciaz4TKEPzgpDYEt1JOpyUC1tzAFMQcG/iWeMUd91pxGKJAMJegj0WPVKdoopwh5ixPdL/JJLva7pxWWe9vj6Ut4o77nDyytBdGJrgN/VSdBseGFrZDMg08jyPFDNb7FQ==;25:akjvjFlk28zNdPlnfBapEpbjOgwrFercZ1p8C8x5/sWAL+Nl0sQcLYKL1mSvxwXDHwLdwCho4w1QOn4WTLF2RymfG7l5IrX8bxsx4HdgDlTUyH4RDWkR6yd6FWeItVLeike3z0F16/u382XsKJjo4Y4PPvdTfhYMHRQktnimxUCd3sM9S4Z/v0weUyJL24ToDW7RsVenvu2cD1VggsUwpXKZyjbfh7xRD+vvO042kUXYQLsKvrOXLdhPu7gpQPwa2lgUZo+S1Ym2DHygkEzV1GGYxCCpxZ/l1QqFFcSQPAP/BTWFysunQ7MMU0nZ/D5OxY6b5aCcm3dHIvJGTlbrB7WPIPM3Qn6Knmh4HFtd73tYkEnakVNNNax8zFdGL5lHKMW2VHlfjp2hsp4oW0zaCj7sfN2gZWwmAnuzg5DpmPEjwe/czbXWKF9wWGSZXhmXR6Rc00HbfwqceFhqBq6ZQQ== X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0460;31:ou/h4V70kg/LBzMQ3xgLagD/x5OU10RpoDRUdXhnU4pYlla6YPlgHnSEwBItsuc/zeAomE6z+PSHroR0VDeBjMbNet13D3v9MUqgLSvieHC5w6mTCS8eKLNmCBbsWp0HpC339SNH1wX3QYpyIljjVtNkiuq71vKpLCN+eoSF9IHUg7l36hOhsRMqP0pWlZ1g90quDu4LtZ9M6W7IPXfuXuF5+bOi3a+7y4SePsNBCfu9nuXhh1GztuFnJZsIQPOpm18Ir7RzcFF9gGgB47LdyvzrQRgkWiTkhsPJOSt/Bg8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13017025)(13024025)(13015025)(13023025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123558025)(20161123564025)(20161123560025)(20161123562025)(6072148);SRVR:CY1PR10MB0460;BCL:0;PCL:0;RULEID:;SRVR:CY1PR10MB0460; X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0460;4:m+Ig2RhTodVyPNr5NJEujO/6HyUyvfBlfFQtyuAnueNYfVP4/x9ZiKXQL4fT+Chb9AWeS/lMxyOeCRDjhTB5jpQXAr+qIJsM/4/D2Zwi763BZiliTMSGLJXLIwjk1Fn+j1VWVEFFJGQkMIkrsSzJ2j37KKE+w2vQVraaZd8Yc5/iylavL10vXqBImXfrg5JFI90m6izAm8eBrnT/KAh0Q9HsEe+F5eWjySEHoptt8UF0fo2qF8taU6P2CMKTz1cz+g1WA4Mzw1mcGmpnX3ZXFihOgtnEp6SOlDavo+4q5/yoMCC4kXlW6pUyQDuQlVjoaj16YLQblP5FoBbsUOkB5MQ47WIpnsizxrrPL+o9kfsYuuF6IWVXW45k6FCP2zI6qvbPSDNW+u4qLbaWqX9d73DOn7r2ESdrxxSrbbzP5qe0d02wp//U7RqgsnaNq8nrMtkCWtfYgXsh0XwAERXrjFXR8dIiigrapv9AeC6xXcvcMMRkBiWKHQcOlS90liEo7o7ipZuhVxQmhJ8QUrxkeoeF+FtqA/YHsXMyQZMcDM733PAAzk4sYN6mpH34JrQEsWTow9fUjZyWpIOwYMaxpqJqbrirmJPuFCcIfF0KzMxUorBpVjTDZrdnjsbdVWJt1q71dDmYwPTNeW5dy2TSe7STiINPBisaik63VVm639LDBJyEAozxNqaR2tD/ffkZmGLGnAgGfc0SE4gGFsX5gA== X-Forefront-PRVS: 022649CC2C X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;CY1PR10MB0460;23:r2bxLdIvdCErJnNdbMOjakzwmiNsLHcEmDdzHB?= =?iso-8859-15?Q?2cwOeLMbeFD17sp/mMLz1whkWUqkoIsjktSAG7uPvjLr2LveZR3X9Bpex?= =?iso-8859-15?Q?2J36TWn8W6U3V18wQAlsNfALwt87iE24uUc5ot9CLpiy1seDFaG7ALTrF?= =?iso-8859-15?Q?do44wm2n3omhv8iqjUN4uFZn+3Z33/dXZ6udlnfdK9thoN5k/PvcnUfwm?= =?iso-8859-15?Q?UWxLwVeF0d4QAscy7dCIbBZKkJG9B3iHuj2RqHwct2GGtR3XIl1w6adHu?= =?iso-8859-15?Q?j2l4vWdh/QP2JvDhzYjtbhwIzq2CrgnJSaMVW5aHRuYPgb0fIAEBKoAWX?= =?iso-8859-15?Q?jfpd3ydUmsZvIHM4Y2S4qhCP5xSidg7ZHj2NELjs0ZVQ11OgBv8GKSilY?= =?iso-8859-15?Q?kiY7Ddouf6smC2p1UhZjX6EUmqAa96CwbEBU6qKJdaN/WvgqKU5b2c9N/?= =?iso-8859-15?Q?iqURCW3snbH918D6l45s+bFOjQs3HDZXHTacS6vPGtprvu7YLd41YxaJp?= =?iso-8859-15?Q?YjyKDI4U/s3I9EX6eC5+RKfrZsUkJfSRuFB03omEnuCcSRJQu77D+asLm?= =?iso-8859-15?Q?cp5XcvpEUt+cun0ekOnJkuIVaaCvJHt/68eTskFkkoKA0eoFuJ1Jc/yFf?= =?iso-8859-15?Q?v6hUm0tFUY5MKCObTXOVBCEvAl1jMrdKC7OKKidh1hU1uhXVrU6Lz2KvV?= =?iso-8859-15?Q?3BweZ0BXy7YP36z2CL9wGj938yXT37u9RQSO7AZsBz+4v0euxddldq5mA?= =?iso-8859-15?Q?k1iPrYTWeiRRIEFUe3lpeVEzswn6dqAR/SsuqcCYxqJ6JJiYjYbGk+hLr?= =?iso-8859-15?Q?Eq7CoaIgF3gaP2bAuF2jmGXCjO8qSHjhoKcTMwhJkhgRZ0uGJmh3CNQ7p?= =?iso-8859-15?Q?4Z+fz27uFzssnpoxMUkKwHp/f60XncG3G8MdhSg3MkXlkgZsYQ3UIRlU3?= =?iso-8859-15?Q?Thkq7MmxytDcDXHD4jDmT2RTx1xO81DGM4bXOgsy2++iALGmXetQYJZvo?= =?iso-8859-15?Q?TfFmTPevalDLwnedg1GKJSjdMl7UO1pxV7FSLIKYiUxCsx9Ezem/lPalf?= =?iso-8859-15?Q?MxECVR5EY3+A+7QHYvQvJlaDUEPE9ZABxHoOM2Xyx+h4JWNbJFe2ksBgK?= =?iso-8859-15?Q?AuOuAf21t5Tne2LtbWWOCWQoivXdxktVOAyDpnOaZ6tJlSfZzRm1VpJr7?= =?iso-8859-15?Q?F+jd3IaFaekszhm49cDmqXJapZcHRiXPtPi65k5W24fjx15C78n6BzktX?= =?iso-8859-15?Q?jJnqiDtewufLmwDGnTN0MEfyFadF8B0ENaTorrZjxTeHmLWD9Wo6yf4WW?= =?iso-8859-15?Q?4b1+VDb9K3ig4W0GPkCfYuq1S+dl84VJv50eXPr41jmMI?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0460;6:/0Z1ApzLOZ4XXyU5pY49ntDqyk/3n5tmcXCZM1G/5NAfpSDSqIBsMPtiVxB1zSFspKWEQ9Z7ktoYXZSoNrMJeNYH1jr1iqhy9uLTpKK/Squd80NsbXeXNa8qq1tusE9pNzloc5y1cttaXczkmuAL+goVZ1JZscGQWbVgm7/nzUTH110hL5NyDl3ESOtxqnswXHDZ2doAYSAE92NoZMWH5kGMtw0auiXEwAACIC0FH1xy2M32+8ENtmWwZ12zZDoV3SvlBKmcm5+zLERuMKTO8cPf8dhQGBLpUVhK03TN3epaE/+YmZ6kUMsnyY60BRT2x/zFzWwUS/MT5PMygG22W3qoozB1+KlZ5NrJcwCbMeT3aqYWzHteiRuVoZ/U1ltTAfvDD3VcP/YY3/eafMqxWA==;5:+JJOlPqeBcbbbluAOOYbpzdzERyJLUBr+C9BHjuBvefoI5h1weBOi3HVYgbup+/ESxTgNLsa1f0jri2rPpTnW0YAsT8UNvP/wkCsDx5/lwftMzQDtgRIq+cU6E737DFAdkvlywLZW83Uh2s6eDLjqA==;24:fWS2H+YCkCFoFl+yl1FuLnn9Yjdvl4avMuZkvUQVL1zoOG3EaZpqv5ylI6hNA5Dq6iYzeoYJ9dRG3ZfhUwS2d/AqWwXiwplr+VII/8IlAz4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0460;7:mia+vZdxp9Y/FhIXIeTq6RW/9Z2mWYqAzzx3oy8LfeNWB1YZhixIte9iSzlHuJM7Z+3y/Cwb3zsiutx+8J39pqqX3eyisbij6XHtg6R7kk3vkgZTugc9zJV4UgIoA4t0yxgzaAIJZ8HV9NaDhTbheFl0zD+BK+Gi2U4dGthqHtXUEbCz+NQ5Iw1sjQgr2AgriZCDanE9RTzkVZC/Jvs3joE/U0o5rF01rzOTkTmxcbcU7eSBsiYxOjCAud08aclYh/rCSjNXOyD5vFNuwNuu9qWlUu9bZ6kk1CIfd5AtAJZV0uAmpAGcIy1deb1DFm7xQQKmMB/ac/ljejk/slNQhw== X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 07:50:47.6367 (UTC) X-MS-Exchange-CrossTenant-Id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;Ip=[204.128.141.24];Helo=[owa.infinera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR10MB0460 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1M7pF4C002439 On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > Signed-off-by: Joakim Tjernlund > > --- > > include/linux/printk.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h > > index 3472cc6..be823f5 100644 > > --- a/include/linux/printk.h > > +++ b/include/linux/printk.h > > > Why are you building this file with a C++ compiler? virtualbox uses C++ and includes various kernel headers and the build fails, virtualbox guest additions has not build for quite some time now and this is one of the problems. > > Also, this is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. Sorry, I was in a hurry(lazy:) so I just included stable directly as I know it needs to be fixed in 4.9 as well. Jocke