From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbdBVKIi (ORCPT ); Wed, 22 Feb 2017 05:08:38 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36253 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbdBVKIa (ORCPT ); Wed, 22 Feb 2017 05:08:30 -0500 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Taeung Song Subject: [PATCH 0/4] perf annotate: Fixes for line numbers and Introduce source_code Date: Wed, 22 Feb 2017 19:08:19 +0900 Message-Id: <1487758103-7953-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, :) Currently perf-annotate have several problems. - Wrong line numbers on perf-annotate (both stdio and TUI) - Wrong sum of overhead(percent) matching source lines - It's so confusing that the output is mixed with both source code and assembly code. (related to depending on 'objdump -S') So fix them regarding wrong line numbers and Introduce new source_code collecting actual code, not depending on 'objdump -S'. In near future, I have a plan for new reable annotate view base on source code (per function(sym)) using the 'struct source_code'. :) I'd appreciate some feedback. (Current v1 don't consider improvement of performance of annotate and don't make code of annotate more compact so I'll consider them in v2) Thanks, Taeung Taeung Song (4): perf annotate: Remove needless regular expression for filename:linenr perf annotate: Align filename:linenr and more correct summary perf annotate: Change the method counting line numbers perf annotate: Introduce source_code to collect actual code tools/perf/util/annotate.c | 174 +++++++++++++++++++++++++++++++++++---------- tools/perf/util/annotate.h | 7 ++ 2 files changed, 144 insertions(+), 37 deletions(-) -- 2.7.4