From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbdBXKAA (ORCPT ); Fri, 24 Feb 2017 05:00:00 -0500 Received: from mailgw01.mediatek.com ([218.249.47.110]:49567 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751268AbdBXJ7x (ORCPT ); Fri, 24 Feb 2017 04:59:53 -0500 Message-ID: <1487930376.22858.14.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/3] mmc: dt-bindings: update Mediatek MMC bindings From: Yong Mao To: Rob Herring , Ulf Hansson CC: Linus Walleij , Chaotian Jing , Eddie Huang , Chunfeng Yun , "linux-mmc@vger.kernel.org" , srv_heupstream , , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Date: Fri, 24 Feb 2017 17:59:36 +0800 In-Reply-To: References: <1484988923-1543-1-git-send-email-yong.mao@mediatek.com> <1484988923-1543-2-git-send-email-yong.mao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Rob, Could you please help to make comments for this patch? Thanks. On Tue, 2017-01-24 at 09:02 +0100, Ulf Hansson wrote: > +Rob, devicetree > > On 21 January 2017 at 09:55, Yong Mao wrote: > > From: yong mao > > > > Add description for mediatek,hs200-cmd-int-delay > > Add description for mediatek,hs400-cmd-int-delay > > Add description for mediatek,hs400-cmd-resp-sel-rising > > > > Signed-off-by: Yong Mao > > You need an ack from a DT maintainer for this. I have added Rob and > the devicetree list on cc. > > Kind regards > Uffe > > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 0120c7f..4182ea3 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -21,6 +21,15 @@ Optional properties: > > - assigned-clocks: PLL of the source clock > > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > > - hs400-ds-delay: HS400 DS delay setting > > +- mediatek,hs200-cmd-int-delay: HS200 command internal delay setting. > > + This field has total 32 stages. > > + The value is an integer from 0 to 31. > > +- mediatek,hs400-cmd-int-delay: HS400 command internal delay setting > > + This field has total 32 stages. > > + The value is an integer from 0 to 31. > > +- mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection > > + If present,HS400 command responses are sampled on rising edges. > > + If not present,HS400 command responses are sampled on falling edges. > > > > Examples: > > mmc0: mmc@11230000 { > > @@ -38,4 +47,7 @@ mmc0: mmc@11230000 { > > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > > hs400-ds-delay = <0x14015>; > > + mediatek,hs200-cmd-int-delay = <26>; > > + mediatek,hs400-cmd-int-delay = <14>; > > + mediatek,hs400-cmd-resp-sel-rising; > > }; > > -- > > 1.7.9.5 > >