From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752356AbdBZQNx (ORCPT ); Sun, 26 Feb 2017 11:13:53 -0500 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:59029 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752271AbdBZQNr (ORCPT ); Sun, 26 Feb 2017 11:13:47 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1362:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:4321:4605:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12438:12555:12740:12760:12895:12986:13069:13311:13357:13439:14181:14659:14721:21060:21080:21365:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: nut83_4da85ff16b45d X-Filterd-Recvd-Size: 2050 Message-ID: <1488125531.9188.1.camel@perches.com> Subject: Re: [PATCH v3] staging: xgifb: correct the multiple line dereference From: Joe Perches To: Arushi Singhal , arnaud.patard@rtp-net.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Sun, 26 Feb 2017 08:12:11 -0800 In-Reply-To: <20170226155329.GA19949@arushi-HP-Pavilion-Notebook> References: <20170226155329.GA19949@arushi-HP-Pavilion-Notebook> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. [] > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c [] > @@ -878,30 +878,18 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) > [] > xgifb_reg_set( > - XGIPART2, > - 0x37, > - (XGI_TV_filter[filter_tb]. > - filter[filter][2])); > + XGIPART2, 0x35, f[0]); > + xgifb_reg_set( > + XGIPART2, 0x36, f[1]); > + xgifb_reg_set( > + XGIPART2, 0x37, f[2]); 0 1 2 3 4 5 6 7 8 12345678901234567890123456789012345678901234567890123456789012345678901234567890 xgifb_reg_set(XGIPART2, 0x37, f[2]); All of these fit nicely on a single line and you should submit patches that make the most sense and do not need revision when reformatting. Please reformat all instances as above and resubmit.