From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdB0Xns (ORCPT ); Mon, 27 Feb 2017 18:43:48 -0500 Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:45726 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751783AbdB0Xnj (ORCPT ); Mon, 27 Feb 2017 18:43:39 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:69:355:379:541:599:800:960:967:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2561:2564:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:7514:7903:9025:9389:10004:10400:10848:11232:11658:11914:12043:12296:12438:12555:12700:12737:12740:12760:12895:13439:14181:14659:14721:21080:21451:30054:30062:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: sense11_64566664d2329 X-Filterd-Recvd-Size: 2970 Message-ID: <1488236686.25838.16.camel@perches.com> Subject: Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks From: Joe Perches To: Ruslan Bilovol , apw@canonical.com, Andrew Morton Cc: linux-kernel@vger.kernel.org, keescook@chromium.org Date: Mon, 27 Feb 2017 15:04:46 -0800 In-Reply-To: <1488234097-20119-1-git-send-email-ruslan.bilovol@gmail.com> References: <1488234097-20119-1-git-send-email-ruslan.bilovol@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-28 at 00:21 +0200, Ruslan Bilovol wrote: > Config EXPERIMENTAL has been removed from kernel in 2013 > (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"), > there is no any reason to do these checks now. > Signed-off-by: Ruslan Bilovol While I think all the defconfigs that have CONFIG_EXPERIMENTAL should have those lines removed, this seems sensible enough. $ git grep -w CONFIG_EXPERIMENTAL -- "*defconfig*" | wc -l 216 Acked-by: Joe Perches Here's a little script to remove the CONFIG_EXPERIMENTAL lines from all the defconfigs too: $ git grep -w --name-only CONFIG_EXPERIMENTAL -- "*defconfig*" | \ xargs sed -i -e '/CONFIG_EXPERIMENTAL=[yn]/d' > --- > scripts/checkpatch.pl | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 982c52c..e0a34e6 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2746,13 +2746,6 @@ sub process { > #print "is_start<$is_start> is_end<$is_end> length<$length>\n"; > } > > -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig. > - if ($realfile =~ /Kconfig/ && > - $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) { > - WARN("CONFIG_EXPERIMENTAL", > - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n"); > - } > - > # discourage the use of boolean for type definition attributes of Kconfig options > if ($realfile =~ /Kconfig/ && > $line =~ /^\+\s*\bboolean\b/) { > @@ -3146,12 +3139,6 @@ sub process { > } > } > > -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def). > - if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) { > - WARN("CONFIG_EXPERIMENTAL", > - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n"); > - } > - > # check for RCS/CVS revision markers > if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { > WARN("CVS_KEYWORD",