From: kys@exchange.microsoft.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
leann.ogasawara@canonical.com
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 04/10] vmbus: remove useless return's
Date: Mon, 27 Feb 2017 20:05:27 -0700 [thread overview]
Message-ID: <1488251133-32767-4-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1488251083-32718-1-git-send-email-kys@exchange.microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
No need for empty return at end of void function
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv_balloon.c | 2 --
drivers/hv/hv_fcopy.c | 2 --
drivers/hv/hv_kvp.c | 2 --
drivers/hv/hv_snapshot.c | 2 --
drivers/hv/ring_buffer.c | 2 --
drivers/hv/vmbus_drv.c | 2 --
include/linux/hyperv.h | 2 --
7 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 5fd03e5..f5728de 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -722,8 +722,6 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size,
5*HZ);
post_status(&dm_device);
}
-
- return;
}
static void hv_online_page(struct page *pg)
diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c
index 545cf43..778ad80 100644
--- a/drivers/hv/hv_fcopy.c
+++ b/drivers/hv/hv_fcopy.c
@@ -187,8 +187,6 @@ static void fcopy_send_data(struct work_struct *dummy)
}
}
kfree(smsg_out);
-
- return;
}
/*
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
index 15c7873..bc4a4da 100644
--- a/drivers/hv/hv_kvp.c
+++ b/drivers/hv/hv_kvp.c
@@ -484,8 +484,6 @@ static void process_ib_ipinfo(void *in_msg, void *out_msg, int op)
}
kfree(message);
-
- return;
}
/*
diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c
index 3847f19..3cb05f4 100644
--- a/drivers/hv/hv_snapshot.c
+++ b/drivers/hv/hv_snapshot.c
@@ -213,8 +213,6 @@ static void vss_send_op(void)
}
kfree(vss_msg);
-
- return;
}
static void vss_handle_request(struct work_struct *dummy)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 87799e8..d0ff5b4 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -73,8 +73,6 @@ static void hv_signal_on_write(u32 old_write, struct vmbus_channel *channel)
*/
if (old_write == READ_ONCE(rbi->ring_buffer->read_index))
vmbus_setevent(channel);
-
- return;
}
/* Get the next write location for the specified ring buffer. */
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 971ecb7..9ddbf4d 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -785,8 +785,6 @@ static void vmbus_shutdown(struct device *child_device)
if (drv->shutdown)
drv->shutdown(dev);
-
- return;
}
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index c4c7ae9..443788e 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1507,8 +1507,6 @@ static inline void hv_signal_on_read(struct vmbus_channel *channel)
cached_write_sz = hv_get_cached_bytes_to_write(rbi);
if (cached_write_sz < pending_sz)
vmbus_setevent(channel);
-
- return;
}
static inline void
--
1.7.1
next prev parent reply other threads:[~2017-02-28 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 3:04 [PATCH 00/10] Drivers: hv: vmbus: Miscellaneous fixes kys
2017-02-28 3:05 ` [PATCH 01/10] vmbus: only reschedule tasklet if time limit exceeded kys
2017-02-28 3:05 ` [PATCH 02/10] vmbus: use rcu for per-cpu channel list kys
2017-02-28 3:05 ` [PATCH 03/10] hyperv: fix warning about missing prototype kys
2017-02-28 3:05 ` kys [this message]
2017-02-28 3:05 ` [PATCH 05/10] vmbus: remove unnecessary initialization kys
2017-02-28 3:05 ` [PATCH 06/10] vmbus: fix spelling errors kys
2017-02-28 3:05 ` [PATCH 07/10] hyperv: remove unnecessary return variable kys
2017-02-28 3:05 ` [PATCH 08/10] vmbus: make channel_message table constant kys
2017-02-28 3:05 ` [PATCH 09/10] vmbus: cleanup header file style kys
2017-02-28 3:05 ` [PATCH 10/10] vmbus: expose debug info for drivers kys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488251133-32767-4-git-send-email-kys@exchange.microsoft.com \
--to=kys@exchange.microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®