From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
arnaud.patard@rtp-net.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v7] staging: xgifb: correct the multiple line dereference
Date: Tue, 28 Feb 2017 03:29:53 -0800 [thread overview]
Message-ID: <1488281393.25838.27.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702281220220.3056@hadrien>
On Tue, 2017-02-28 at 12:24 +0100, Julia Lawall wrote:
> It's drifting a little bit from the original issue, but the whole *i thing
> is not very nice. The function is used in only one place, and the call
> looks like this:
>
> temp = XGI_AjustCRT2Rate(ModeIdIndex, RefreshRateTableIndex,
> &i, pVBInfo);
>
> immediately followed by:
>
> return RefreshRateTableIndex + i;
>
> temp is never used. Could the function be made to return a negative error
> code on failure and the updated value of i on success? The (*i) could
> become just i, which would even be a little shorter.
I don't see why not.
prev parent reply other threads:[~2017-02-28 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 10:45 Arushi Singhal
2017-02-28 11:11 ` Joe Perches
2017-02-28 11:24 ` [Outreachy kernel] " Julia Lawall
2017-02-28 11:29 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488281393.25838.27.camel@perches.com \
--to=joe@perches.com \
--cc=arnaud.patard@rtp-net.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome