From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751055AbdB1Ueq (ORCPT ); Tue, 28 Feb 2017 15:34:46 -0500 Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:42757 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751571AbdB1Ueh (ORCPT ); Tue, 28 Feb 2017 15:34:37 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12043:12296:12555:12740:12760:12895:12986:13069:13255:13311:13357:13439:14659:14721:21080:21324:21433:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: soup03_7d580f4de92d X-Filterd-Recvd-Size: 1963 Message-ID: <1488314051.25838.34.camel@perches.com> Subject: Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. From: Joe Perches To: Alexander Kapshuk , thomas.petazzoni@free-electrons.com, noralf@tronnes.org Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 28 Feb 2017 12:34:11 -0800 In-Reply-To: <20170228195244.29205-1-alexander.kapshuk@gmail.com> References: <20170228195244.29205-1-alexander.kapshuk@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote: > Use a single fmt string with appropriate verbs as conversion specifiers, > followed by the original string literals and the integer argument > instead of using a backslash to escape a new line embedded inbetween > quoted string literals passed as fmt arguments to dev_err() invoked in > drivers/staging/fbtft/fb_ssd1331.c. trivia: > diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c > index 26f24e3..6d03041 100644 > --- a/drivers/staging/fbtft/fb_ssd1331.c > +++ b/drivers/staging/fbtft/fb_ssd1331.c > @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves) > > for (i = 0; i < 63; i++) { > if (i > 0 && curves[i] < 2) { > - dev_err(par->info->device, > - "Illegal value in Grayscale Lookup Table at index %d. " \ > - "Must be greater than 1\n", i); > + dev_err(par->info->device, "%s %d. %s\n", > + "Illegal value in Grayscale Lookup Table at index", Most prefer the use of invalid not illegal.