From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752300AbdB1Vln (ORCPT ); Tue, 28 Feb 2017 16:41:43 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35326 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbdB1Vld (ORCPT ); Tue, 28 Feb 2017 16:41:33 -0500 Message-ID: <1488318090.21996.2.camel@baylibre.com> Subject: Re: [PATCH] clk: meson: fix SET_PARM macro From: Jerome Brunet To: Stephen Boyd Cc: Michael Turquette , Kevin Hilman , Carlo Caione , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 28 Feb 2017 22:41:30 +0100 In-Reply-To: <20170228212654.GM25384@codeaurora.org> References: <20170228093016.5624-1-jbrunet@baylibre.com> <20170228212654.GM25384@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-28 at 13:26 -0800, Stephen Boyd wrote: > On 02/28, Jerome Brunet wrote: > > parameter val is not enclosed in parenthesis which is buggy when > > given an > > expression instead of a simple value > > > > Signed-off-by: Jerome Brunet > > Fixes tag? Is there a place in the code that is using a complex > expression for val right now? > Not if with what's already in, afaik. However "clk: meson: mpll: add rw operation" I sent earlier today uses a ternary operator for val. That's  how I found this issue. Instead of running the test, it would always use the "else" clause. I realize I should sent these patches in the same series. Would you prefer me to do so ? Jerome