From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754139AbdCBHEs (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 02:04:48 -0500
Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:51011 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750733AbdCBHEq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 02:04:46 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3870:3873:4321:5007:10004:10400:10848:11026:11232:11658:11914:12048:12296:12438:12740:12895:13069:13161:13229:13311:13357:13439:13894:14659:14721:21080:21212:21434:30012:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: scent96_658687fe11c2b
X-Filterd-Recvd-Size: 1763
Message-ID: <1488437696.2179.3.camel@perches.com>
Subject: Re: [PATCH 2/2] HID: Remove unnecessary OOM messages
From: Joe Perches <joe@perches.com>
To: Michel Hermier <michel.hermier@gmail.com>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bruno =?ISO-8859-1?Q?Pr=E9mont?= <bonbons@linux-vserver.org>,
        Stefan Achatz <erazor_de@users.sourceforge.net>,
        Jonathan Cameron <jic23@kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org
Date: Wed, 01 Mar 2017 22:54:56 -0800
In-Reply-To: <a52260a5-921c-53f9-8709-ae7189395cee@gmail.com>
References: <cover.1488395879.git.joe@perches.com>
         <0fbe692283802d36df389af7cbda9a4bff44db5e.1488395879.git.joe@perches.com>
         <a52260a5-921c-53f9-8709-ae7189395cee@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-03-02 at 07:51 +0100, Michel Hermier wrote:
> Le 01/03/2017 à 20:19, Joe Perches a écrit :
> > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
[]
> > @@ -224,7 +224,6 @@ static int asus_start_multitouch(struct hid_device *hdev)
> >   
> >   	if (!dmabuf) {
> >   		ret = -ENOMEM;
> > -		hid_err(hdev, "Asus failed to alloc dma buf: %d\n", ret);
> >   		return ret;
> >   	}
> 
> Trivial set and return value missed.

You're welcome to submit a follow-on patch.

The compiler should produce the same code
in any case.