From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbdCBRjA (ORCPT ); Thu, 2 Mar 2017 12:39:00 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:47670 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbdCBRi5 (ORCPT ); Thu, 2 Mar 2017 12:38:57 -0500 From: Alexey Brodkin To: Jose Abreu CC: Carlos Palminha , "linux-kernel@vger.kernel.org" , Vineet Gupta , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Thread-Topic: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Thread-Index: AQHSjThIHRXwbSLeikW9D7Gx9mLbl6GBy6wA Date: Thu, 2 Mar 2017 17:35:52 +0000 Message-ID: <1488476152.2684.10.camel@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> In-Reply-To: <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.102] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v22Hd3V9018917 Hi Jose, On Wed, 2017-02-22 at 18:19 +0000, Jose Abreu wrote: > Default clock frequency for ARC PGU does not match any > existing HDMI mode, instead the default value matches a > DVI mode. Change the clock frequency to 74.25MHz so that > it matches HDMI mode 1280x720@60Hz > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Rob Herring > Cc: Vineet Gupta > Cc: devicetree@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- >  arch/arc/boot/dts/axs10x_mb.dtsi | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index 9d882b1..41cfb29 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -51,7 +51,7 @@ >   pguclk: pguclk { >   #clock-cells = <0>; >   compatible = "fixed-clock"; > - clock-frequency = <74440000>; > + clock-frequency = <74250000>; >   }; >   }; Looks good to me but I have to note that with this change in place monitors that don't report [correct] EDID won't work just because if EDID is missing Linux kernel calculates pixel clock on its own and for 1280x720@60 it gets 74.40 MHz which obviously differs from yours 74.25 MHz and so arc_pgu_crtc_atomic_check() returns -EINVAL. But with the fix I just sent, see http://lists.infradead.org/pipermail/linux-snps-arc/2017-March/002173.html everything will work again. And once Vlad's patch for AXS PLLs gets accepted we'll finally get support of multiple modes on AXS10x boards. That said... Acked-by: Alexey Brodkin