From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbbCMKpX (ORCPT ); Fri, 13 Mar 2015 06:45:23 -0400 Received: from mail.eperm.de ([89.247.134.16]:46687 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbbCMKpT (ORCPT ); Fri, 13 Mar 2015 06:45:19 -0400 From: Stephan Mueller To: "'Herbert Xu" Cc: linux-crypto@vger.kernel.org, "'LKML'" Subject: [PATCH RESEND] crypto: algif_rng - zeroize buffer with random data Date: Fri, 13 Mar 2015 11:44:07 +0100 Message-ID: <1488589.sO3PXAYh7F@tachyon.chronox.de> User-Agent: KMail/4.14.4 (Linux/3.18.8-201.fc21.x86_64; KDE/4.14.4; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Due to the change to RNGs to always return zero in success case, the RNG interface must zeroize the buffer with the length provided by the caller. Signed-off-by: Stephan Mueller --- crypto/algif_rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c index 67f612c..a346173 100644 --- a/crypto/algif_rng.c +++ b/crypto/algif_rng.c @@ -87,7 +87,7 @@ static int rng_recvmsg(struct kiocb *unused, struct socket *sock, return genlen; err = memcpy_to_msg(msg, result, len); - memzero_explicit(result, genlen); + memzero_explicit(result, len); return err ? err : len; } -- 2.1.0