From: Joe Perches <joe@perches.com>
To: Ernestas Kulik <ernestas.kulik@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: clean up code
Date: Fri, 03 Mar 2017 23:24:31 -0800 [thread overview]
Message-ID: <1488612271.2179.48.camel@perches.com> (raw)
In-Reply-To: <20170304064927.GA4470@gmail.com>
On Sat, 2017-03-04 at 08:49 +0200, Ernestas Kulik wrote:
> On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote:
> >
> > struct hostif_hdr.event is declared at uint16_t
> > and not as __le16 so I believe this is incorrect
> > and actually introduces a sparse error.
>
> Sure, but I change that in the patch. :)
More stuff the changelog doesn't show :(
On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote:
> This fixes type warnings generated by sparse, replaces instances of
> ntohs() with be16_to_cpu() and removes unused fields in structs.
next prev parent reply other threads:[~2017-03-04 7:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 20:58 Ernestas Kulik
2017-03-04 1:23 ` Joe Perches
2017-03-04 6:28 ` Ernestas Kulik
2017-03-04 6:37 ` Joe Perches
2017-03-04 6:49 ` Ernestas Kulik
2017-03-04 7:24 ` Joe Perches [this message]
2017-03-04 9:04 ` Ernestas Kulik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488612271.2179.48.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=ernestas.kulik@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome