From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbdCDQrl (ORCPT ); Sat, 4 Mar 2017 11:47:41 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35722 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbdCDQri (ORCPT ); Sat, 4 Mar 2017 11:47:38 -0500 From: simran singhal To: w.d.hubbs@gmail.com Cc: chris@the-brannons.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, speakup@linux-speakup.org, linux-rpi-kernel@lists.infradead.org, outreachy-kernel@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] staging: speakup: Clean up tests if NULL returned on failure Date: Sat, 4 Mar 2017 22:16:54 +0530 Message-Id: <1488646015-7059-3-git-send-email-singhalsimran0@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488646015-7059-1-git-send-email-singhalsimran0@gmail.com> References: <1488646015-7059-1-git-send-email-singhalsimran0@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index c2f70ef..e8268bc 100644 --- a/drivers/staging/speakup/main.c +++ b/drivers/staging/speakup/main.c @@ -1324,7 +1324,7 @@ static int speakup_allocate(struct vc_data *vc) if (speakup_console[vc_num] == NULL) { speakup_console[vc_num] = kzalloc(sizeof(*speakup_console[0]), GFP_ATOMIC); - if (speakup_console[vc_num] == NULL) + if (!speakup_console[vc_num]) return -ENOMEM; speakup_date(vc); } else if (!spk_parked) -- 2.7.4