From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753214AbdCFMaZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Mar 2017 07:30:25 -0500
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54994 "EHLO
        relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752773AbdCFMaR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Mar 2017 07:30:17 -0500
X-Originating-IP: 83.155.44.161
Message-ID: <1488803268.28315.4.camel@hadess.net>
Subject: Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in
 power_supply
From: Bastien Nocera <hadess@hadess.net>
To: Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
        Nestor Lopez Casado <nlopezcasad@logitech.com>,
        Olivier Gay <ogay@logitech.com>, Simon Wood <simon@mungewell.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 06 Mar 2017 13:27:48 +0100
In-Reply-To: <alpine.LSU.2.20.1703061317480.31814@cbobk.fhfr.pm>
References: <20170202141229.17322-1-benjamin.tissoires@redhat.com>
         <20170202141229.17322-6-benjamin.tissoires@redhat.com>
         <1486134491.2316.11.camel@hadess.net>
         <20170207083557.GD16529@mail.corp.redhat.com>
         <alpine.LSU.2.20.1703061317480.31814@cbobk.fhfr.pm>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.23.90 (3.23.90-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote:
> On Tue, 7 Feb 2017, Benjamin Tissoires wrote:
> 
> > > > +               case POWER_SUPPLY_PROP_MANUFACTURER:
> > > > +                       val->strval = "Logitech, Inc.";
> > > 
> > > I don't like this change. I'd prefer the concatenated
> > > manufacturer and
> > > model strings leading to user-friendly strings, and "Logitech
> > > T650" is
> > > better than "Logitech, Inc. T650".
> > 
> > Is this the only problematic issue? We are at rc7 already so I
> > would
> > like to have the final version ready ASAP.
> 
> Bastien, do you have any input on the rest of the series please?

My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove
overloads and provide ONLINE" is the blocker.

No particular comments about the rest of the series.