From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>
Subject: [PATCH] genirq: Fix handling of nested shared IRQs
Date: Mon, 6 Mar 2017 16:08:04 +0000 [thread overview]
Message-ID: <1488816484-6029-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
When an IRQ is nested the nested handler is called directly from within the
threaded handler of the parent IRQ, however, the code in handle_nested_irq
only calls a single handler. This means when a shared IRQ is nested only
the first of the shared IRQ handlers will be run. This patch adds a loop
to move through and process all the handlers associated with the IRQ in
handle_nested_irq.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
kernel/irq/chip.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index be3c34e..c6c7f11 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -348,9 +348,12 @@ void handle_nested_irq(unsigned int irq)
irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
raw_spin_unlock_irq(&desc->lock);
- action_ret = action->thread_fn(action->irq, action->dev_id);
- if (!noirqdebug)
- note_interrupt(desc, action_ret);
+ do {
+ action_ret = action->thread_fn(action->irq, action->dev_id);
+ if (!noirqdebug)
+ note_interrupt(desc, action_ret);
+ action = action->next;
+ } while (action);
raw_spin_lock_irq(&desc->lock);
irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
--
2.1.4
next reply other threads:[~2017-03-06 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 16:08 Charles Keepax [this message]
2017-03-06 18:05 ` Thomas Gleixner
2017-03-07 9:15 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488816484-6029-1-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome