mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: inki.dae@samsung.com, jy0922.shim@samsung.com,
	sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org,
	krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com
Cc: javier@osg.samsung.com, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, a.hajda@samsung.com,
	andi.shyti@samsung.com, Hoegeun Kwon <hoegeun.kwon@samsung.com>
Subject: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function
Date: Wed, 08 Mar 2017 13:54:10 +0900	[thread overview]
Message-ID: <1488948852-5380-4-git-send-email-hoegeun.kwon@samsung.com> (raw)
In-Reply-To: <1488948852-5380-1-git-send-email-hoegeun.kwon@samsung.com>

The dsi + panel is a parental relationship, so OF grpah is not needed.
Therefore, the current dsi_parse_dt function will throw an error,
because there is no linked OF graph for the case fimd + dsi + panel.

Parse the Pll burst and esc clock frequency properties in dsi_parse_dt()
and create a bridge_node only if there is an OF graph associated with dsi.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 ++++++++------------------------
 1 file changed, 8 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index f5c04d0..2d4e118 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1652,39 +1652,23 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
 	if (ret < 0)
 		return ret;
 
-	ep = of_graph_get_endpoint_by_regs(node, DSI_PORT_OUT, 0);
-	if (!ep) {
-		dev_err(dev, "no output port with endpoint specified\n");
-		return -EINVAL;
-	}
-
-	ret = exynos_dsi_of_read_u32(ep, "samsung,burst-clock-frequency",
+	ret = exynos_dsi_of_read_u32(node, "samsung,burst-clock-frequency",
 				     &dsi->burst_clk_rate);
 	if (ret < 0)
-		goto end;
+		return ret;
 
-	ret = exynos_dsi_of_read_u32(ep, "samsung,esc-clock-frequency",
+	ret = exynos_dsi_of_read_u32(node, "samsung,esc-clock-frequency",
 				     &dsi->esc_clk_rate);
 	if (ret < 0)
-		goto end;
-
-	of_node_put(ep);
+		return ret;
 
 	ep = of_graph_get_next_endpoint(node, NULL);
-	if (!ep) {
-		ret = -EINVAL;
-		goto end;
-	}
-
-	dsi->bridge_node = of_graph_get_remote_port_parent(ep);
-	if (!dsi->bridge_node) {
-		ret = -EINVAL;
-		goto end;
+	if (ep) {
+		dsi->bridge_node = of_graph_get_remote_port_parent(ep);
+		of_node_put(ep);
 	}
-end:
-	of_node_put(ep);
 
-	return ret;
+	return 0;
 }
 
 static int exynos_dsi_bind(struct device *dev, struct device *master,
-- 
1.9.1

  parent reply	other threads:[~2017-03-08  4:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170308045502epcas1p29b871888e32bb1e2f870b9fd399d0b06@epcas1p2.samsung.com>
2017-03-08  4:54 ` [PATCH v5 0/5] Fix the parse_dt of exynos dsi and remove the OF graph Hoegeun Kwon
     [not found]   ` <CGME20170308045502epcas1p2b16df118e0ad91dbd2446687dc5ee843@epcas1p2.samsung.com>
2017-03-08  4:54     ` [PATCH v5 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node Hoegeun Kwon
2017-03-08  6:58       ` Krzysztof Kozlowski
2017-03-08  7:12       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170308045502epcas1p26f050caaf6eeb79bc88afcb0e2eaeac2@epcas1p2.samsung.com>
2017-03-08  4:54     ` [PATCH v5 2/5] arm: dts: " Hoegeun Kwon
2017-03-08  6:58       ` Krzysztof Kozlowski
2017-03-08  7:14       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170308045502epcas1p2d2f7a0f768082b7a54b2ebe260e78436@epcas1p2.samsung.com>
2017-03-08  4:54     ` Hoegeun Kwon [this message]
2017-03-22  1:36       ` [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function Hoegeun Kwon
2017-03-28  8:26         ` Inki Dae
2017-03-28  8:38           ` Krzysztof Kozlowski
2017-04-04 15:38             ` Krzysztof Kozlowski
2017-04-06  4:33               ` Inki Dae
2017-04-06  6:48               ` Inki Dae
     [not found]   ` <CGME20170308045502epcas1p21a483d429e2169b322e40fd833c47f27@epcas1p2.samsung.com>
2017-03-08  4:54     ` [PATCH v5 4/5] arm64: dts: exynos: Remove the OF graph from DSI node Hoegeun Kwon
2017-05-15 16:48       ` Krzysztof Kozlowski
2017-05-19  6:17         ` Hoegeun Kwon
2017-06-07  6:14           ` Hoegeun Kwon
2017-06-09  7:37             ` Krzysztof Kozlowski
2017-07-18  5:03       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170308045503epcas1p2759ce089ec0e0d0a79c7d88e45efe9cc@epcas1p2.samsung.com>
2017-03-08  4:54     ` [PATCH v5 5/5] arm: dts: " Hoegeun Kwon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488948852-5380-4-git-send-email-hoegeun.kwon@samsung.com \
    --to=hoegeun.kwon@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=andi.shyti@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sw0312.kim@samsung.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®