From: Magnus Damm <magnus.damm@gmail.com>
To: joro@8bytes.org
Cc: laurent.pinchart+renesas@ideasonboard.com,
geert+renesas@glider.be, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
iommu@lists.linux-foundation.org, horms+renesas@verge.net.au,
Magnus Damm <magnus.damm@gmail.com>,
robin.murphy@arm.com, m.szyprowski@samsung.com
Subject: [PATCH v3 06/09] iommu/ipmmu-vmsa: Write IMCTR twice
Date: Wed, 08 Mar 2017 20:02:23 +0900 [thread overview]
Message-ID: <148897094380.16106.17145886836361556040.sendpatchset@little-apple> (raw)
In-Reply-To: <148897088333.16106.13237004440297956899.sendpatchset@little-apple>
From: Magnus Damm <damm+renesas@opensource.se>
Write IMCTR both in the root device and the leaf node.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Changes since V2:
- None
Changes since V1:
- None
drivers/iommu/ipmmu-vmsa.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
--- 0018/drivers/iommu/ipmmu-vmsa.c
+++ work/drivers/iommu/ipmmu-vmsa.c 2017-03-08 18:30:36.870607110 +0900
@@ -286,6 +286,16 @@ static void ipmmu_ctx_write(struct ipmmu
ipmmu_write(domain->root, domain->context_id * IM_CTX_SIZE + reg, data);
}
+static void ipmmu_ctx_write2(struct ipmmu_vmsa_domain *domain, unsigned int reg,
+ u32 data)
+{
+ if (domain->mmu != domain->root)
+ ipmmu_write(domain->mmu,
+ domain->context_id * IM_CTX_SIZE + reg, data);
+
+ ipmmu_write(domain->root, domain->context_id * IM_CTX_SIZE + reg, data);
+}
+
/* -----------------------------------------------------------------------------
* TLB and microTLB Management
*/
@@ -312,7 +322,7 @@ static void ipmmu_tlb_invalidate(struct
reg = ipmmu_ctx_read(domain, IMCTR);
reg |= IMCTR_FLUSH;
- ipmmu_ctx_write(domain, IMCTR, reg);
+ ipmmu_ctx_write2(domain, IMCTR, reg);
ipmmu_tlb_sync(domain);
}
@@ -472,7 +482,8 @@ static int ipmmu_domain_init_context(str
* software management as we have no use for it. Flush the TLB as
* required when modifying the context registers.
*/
- ipmmu_ctx_write(domain, IMCTR, IMCTR_INTEN | IMCTR_FLUSH | IMCTR_MMUEN);
+ ipmmu_ctx_write2(domain, IMCTR,
+ IMCTR_INTEN | IMCTR_FLUSH | IMCTR_MMUEN);
return 0;
}
@@ -498,7 +509,7 @@ static void ipmmu_domain_destroy_context
*
* TODO: Is TLB flush really needed ?
*/
- ipmmu_ctx_write(domain, IMCTR, IMCTR_FLUSH);
+ ipmmu_ctx_write2(domain, IMCTR, IMCTR_FLUSH);
ipmmu_tlb_sync(domain);
ipmmu_domain_free_context(domain->root, domain->context_id);
}
next prev parent reply other threads:[~2017-03-08 11:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 11:01 [PATCH v3 00/09] iommu/ipmmu-vmsa: r8a7795 support V3 Magnus Damm
2017-03-08 11:01 ` [PATCH v3 01/09] iommu/ipmmu-vmsa: Introduce features, break out alias Magnus Damm
2017-03-08 11:53 ` Robin Murphy
2017-03-09 4:01 ` Magnus Damm
2017-03-08 11:01 ` [PATCH v3 02/09] iommu/ipmmu-vmsa: Add optional root device feature Magnus Damm
2017-03-08 13:47 ` Geert Uytterhoeven
2017-03-09 4:29 ` Magnus Damm
2017-03-08 11:01 ` [PATCH v3 03/09] iommu/ipmmu-vmsa: Enable multi context support Magnus Damm
2017-03-08 12:21 ` Robin Murphy
2017-03-09 4:16 ` Magnus Damm
2017-03-08 11:02 ` [PATCH v3 04/09] iommu/ipmmu-vmsa: Make use of IOMMU_OF_DECLARE() Magnus Damm
2017-03-08 13:52 ` Geert Uytterhoeven
2017-03-09 3:55 ` Magnus Damm
2017-03-08 11:02 ` [PATCH v3 05/09] iommu/ipmmu-vmsa: IPMMU device is 40-bit bus master Magnus Damm
2017-03-08 11:02 ` Magnus Damm [this message]
2017-03-08 12:34 ` [PATCH v3 06/09] iommu/ipmmu-vmsa: Write IMCTR twice Robin Murphy
2017-03-09 3:57 ` Magnus Damm
2017-03-08 11:02 ` [PATCH v3 07/09] iommu/ipmmu-vmsa: Make IMBUSCTR setup optional Magnus Damm
2017-03-08 11:02 ` [PATCH v3 08/09] iommu/ipmmu-vmsa: Allow two bit SL0 Magnus Damm
2017-03-08 11:02 ` [PATCH v3 09/09] iommu/ipmmu-vmsa: Hook up r8a7795 DT matching code Magnus Damm
2017-03-08 13:58 ` Geert Uytterhoeven
2017-03-09 4:20 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148897094380.16106.17145886836361556040.sendpatchset@little-apple \
--to=magnus.damm@gmail.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®