From: Madalin Bucur <madalin.bucur@nxp.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <camelia.groza@nxp.com>,
<dan.carpenter@oracle.com>, <linux-kernel@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>,
Madalin Bucur <madalin.bucur@nxp.com>
Subject: [net-next v2 03/10] fsl/fman: remove wrong free
Date: Thu, 9 Mar 2017 16:36:58 +0200 [thread overview]
Message-ID: <1489070225-7891-4-git-send-email-madalin.bucur@nxp.com> (raw)
In-Reply-To: <1489070225-7891-1-git-send-email-madalin.bucur@nxp.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
drivers/net/ethernet/freescale/fman/fman_port.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c
index f314348..57bf44f 100644
--- a/drivers/net/ethernet/freescale/fman/fman_port.c
+++ b/drivers/net/ethernet/freescale/fman/fman_port.c
@@ -1312,7 +1312,7 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params)
/* Allocate the FM driver's parameters structure */
port->cfg = kzalloc(sizeof(*port->cfg), GFP_KERNEL);
if (!port->cfg)
- goto err_params;
+ return -EINVAL;
/* Initialize FM port parameters which will be kept by the driver */
port->port_type = port->dts_params.type;
@@ -1393,8 +1393,6 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params)
err_port_cfg:
kfree(port->cfg);
-err_params:
- kfree(port);
return -EINVAL;
}
EXPORT_SYMBOL(fman_port_config);
--
2.1.0
next prev parent reply other threads:[~2017-03-09 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 14:36 [net-next v2 00/10] QorIQ DPAA 1 updates Madalin Bucur
2017-03-09 14:36 ` [net-next v2 01/10] fsl/fman: parse result data is big endian Madalin Bucur
2017-03-09 14:36 ` [net-next v2 02/10] fsl/fman: set HW parser as BMI next engine Madalin Bucur
2017-03-09 14:36 ` Madalin Bucur [this message]
2017-03-09 14:36 ` [net-next v2 04/10] fsl/fman: enlarge FIFO to allow for the 5th port Madalin Bucur
2017-03-09 14:37 ` [net-next v2 05/10] dpaa_eth: remove redundant initialization Madalin Bucur
2017-03-09 14:37 ` [net-next v2 06/10] dpaa_eth: enable Rx checksum offload Madalin Bucur
2017-03-09 14:37 ` [net-next v2 07/10] dpaa_eth: do not ignore port api return value Madalin Bucur
2017-03-09 14:37 ` [net-next v2 08/10] dpaa_eth: add four prioritised Tx traffic classes Madalin Bucur
2017-03-09 14:37 ` [net-next v2 09/10] dpaa_eth: enable multiple " Madalin Bucur
2017-03-09 14:37 ` [net-next v2 10/10] dpaa_eth: enable context-A stashing Madalin Bucur
2017-03-13 6:01 ` [net-next v2 00/10] QorIQ DPAA 1 updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489070225-7891-4-git-send-email-madalin.bucur@nxp.com \
--to=madalin.bucur@nxp.com \
--cc=camelia.groza@nxp.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®