From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: mathieu.poirier@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
Chunyan Zhang <zhang.chunyan@linaro.org>,
linux-kernel@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH 1/2] coresight: Disable the path only when the source is disabled
Date: Thu, 9 Mar 2017 15:27:11 +0000 [thread overview]
Message-ID: <1489073232-5093-2-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1489073232-5093-1-git-send-email-suzuki.poulose@arm.com>
With a coresight tracing session, the components along the path
from the source to sink are disabled after the source is disabled.
However, if the source was not actually disabled due to active
users, we should not disable the components in the path.
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
drivers/hwtracing/coresight/coresight.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 0c37356..34cd1ed 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -253,7 +253,8 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
return 0;
}
-static void coresight_disable_source(struct coresight_device *csdev)
+/* coresight_disable_source: Returns true if the device has been disabled */
+static bool coresight_disable_source(struct coresight_device *csdev)
{
if (atomic_dec_return(csdev->refcnt) == 0) {
if (source_ops(csdev)->disable) {
@@ -261,6 +262,7 @@ static void coresight_disable_source(struct coresight_device *csdev)
csdev->enable = false;
}
}
+ return !csdev->enable;
}
void coresight_disable_path(struct list_head *path)
@@ -629,7 +631,7 @@ void coresight_disable(struct coresight_device *csdev)
if (ret)
goto out;
- if (!csdev->enable)
+ if (!csdev->enable || !coresight_disable_source(csdev))
goto out;
switch (csdev->subtype.source_subtype) {
@@ -647,7 +649,6 @@ void coresight_disable(struct coresight_device *csdev)
break;
}
- coresight_disable_source(csdev);
coresight_disable_path(path);
coresight_release_path(path);
--
2.7.4
next prev parent reply other threads:[~2017-03-09 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 15:27 [PATCH 0/2] coresight: Allow sharing of STM Suzuki K Poulose
2017-03-09 15:27 ` Suzuki K Poulose [this message]
2017-03-14 17:37 ` [1/2] coresight: Disable the path only when the source is disabled Mathieu Poirier
2017-03-14 17:39 ` Suzuki K Poulose
2017-03-09 15:27 ` [PATCH 2/2] coresight: Fix reference count for software sources Suzuki K Poulose
2017-03-14 17:40 ` [2/2] " Mathieu Poirier
2017-03-14 17:55 ` Suzuki K Poulose
2017-03-14 19:32 ` Mathieu Poirier
2017-03-14 18:06 ` Suzuki K Poulose
2017-03-15 3:51 ` Chunyan Zhang
2017-03-15 16:00 ` Suzuki K Poulose
2017-03-16 12:13 ` Chunyan Zhang
2017-03-17 10:36 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489073232-5093-2-git-send-email-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®