From: Calvin Walton <calvin.walton@kepstin.ca>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Bind RMI4 over SMBus from PS/2
Date: Sat, 11 Mar 2017 09:54:37 -0500 [thread overview]
Message-ID: <1489244077.1857.2.camel@kepstin.ca> (raw)
In-Reply-To: <20170308152445.12082-1-benjamin.tissoires@redhat.com>
Hi,
On Wed, 2017-03-08 at 16:24 +0100, Benjamin Tissoires wrote:
> Hi Dmitry,
>
> This is mostly a resend of the PS/2-SMBus binding (last 3 patches of
> now 3 years
> of trial and errors).
> I integrated both warnings raised by Coccinelle, and squashed 4/3
> into 3/3.
Just want to provide you some quick feedback from the user's
perspective...
I tested this patch set on my somewhat hacked together laptop - I have
a Lenovo T440p with the touchpad replaced with a "top button pad" from
a T450 or similar.
With this patch set (and using the psmouse.synaptics_intertouch=1
option), the touchpad is found and used via RMI4/SMBUS, and the PS2
passthrough to the trackpoint does work. Passing the buttons presses
from the top buttons to the trackpoint device doesn't work - my
understanding is the code for this isn't included here?
The touchpad cursor movement (and scrolling, etc.) is so much smoother
than with the PS2 interface of this touchpad model... I'm glad these
patches are getting closer to complete!
Calvin.
[ 17.665070] psmouse serio1: synaptics: queried max coordinates: x [..5676], y [..4758]
[ 17.698107] psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1096..]
[ 17.760612] psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1, caps: 0xf003a3/0x943300/0x12e800/0x10000, board id: 3053, fw id: 2560
[ 17.763619] psmouse serio1: synaptics: serio: Synaptics pass-through port at isa0060/serio1/input0
[ 17.766577] psmouse serio1: synaptics: device also supported by an other bus.
[ 17.807548] input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio1/input/input9
[ 18.435205] psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 3/3
[ 18.630809] input: TPPS/2 IBM TrackPoint as /devices/platform/i8042/serio1/serio2/input/input18
[ 19.064659] rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3053-003, fw id: 1741108
[ 19.131839] input: Synaptics TM3053-003 as /devices/rmi4-00/input/input19
[ 19.152671] rmi4_smbus 9-002c: registered rmi smb driver at 0x2c.
[ 20.425233] psmouse serio3: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 3/3
[ 20.482937] input: TPPS/2 IBM TrackPoint as /devices/rmi4-00/rmi4-00.fn03/serio3/input/input21
--
Calvin Walton <calvin.walton@kepstin.ca>
next prev parent reply other threads:[~2017-03-11 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 15:24 Benjamin Tissoires
2017-03-08 15:24 ` [PATCH v3 1/3] input: serio - allow others to specify a driver for a serio device Benjamin Tissoires
2017-03-08 15:24 ` [PATCH v3 2/3] Input: synaptics - allocate a Synaptics Intertouch device Benjamin Tissoires
2017-03-08 15:24 ` [PATCH v3 3/3] Input: add a PS/2 to SMBus platform module Benjamin Tissoires
2017-03-11 14:54 ` Calvin Walton [this message]
2017-03-13 9:30 ` [PATCH v3 0/3] Bind RMI4 over SMBus from PS/2 Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489244077.1857.2.camel@kepstin.ca \
--to=calvin.walton@kepstin.ca \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®