From: Dongjiu Geng <gengdongjiu@huawei.com>
To: <benh@kernel.crashing.org>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <linux-kernel@vger.kernel.org>
Cc: <zhanghaibin7@huawei.com>, <huangshaoyu@huawei.com>
Subject: [PATCH v2-kernel 4.1] irqdomain: handle the per-CPU irq trigger type settings
Date: Mon, 13 Mar 2017 13:00:26 +0800 [thread overview]
Message-ID: <1489381226-8806-1-git-send-email-gengdongjiu@huawei.com> (raw)
when percpu devices set its IRQ trigger type using irq_of_parse
and_map API,it will be failed because irq_set_irq_type is only
for 1-N mode interrupt source,not for per-cpu interrupt source.
so handle per-cpu IRQs for this failure.
problem: per cpu device call irq_of_parse_and_map to set its
timer trigger type IRQ_TYPE_EDGE_RISING, irq_of_parse_and_map
will call irq_create_of_mapping to set trigger_type through
irq_set_irq_type. But irq_set_irq_type uses
IRQ_GET_DESC_CHECK_GLOBAL and not IRQ_GET_DESC_CHECK_PERCPU.
per-cpu IRQ is per-cpu and not global.
solution: storing the type into irqdata, then get this IRQ
type fromirq_get_trigger_type, and enable_percpu_irq sets the
type
Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Signed-off-by: Haibin Zhang <zhanghaibin7@huawei.com>
---
kernel/irq/irqdomain.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 9fd618d..8116cf2 100755
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -542,8 +542,16 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
/* Set type if specified and different than the current one */
if (type != IRQ_TYPE_NONE &&
- type != irq_get_trigger_type(virq))
- irq_set_irq_type(virq, type);
+ type != irq_get_trigger_type(virq)) {
+ int ret = 0;
+ struct irq_data *irq_data = irq_get_irq_data(virq);
+
+ ret = irq_set_irq_type(virq, type);
+
+ /* Handle per-cpu IRQ: just save type in irq_data */
+ if (-EINVAL == ret && irq_data)
+ irqd_set_trigger_type(irq_data, type);
+ }
return virq;
}
EXPORT_SYMBOL_GPL(irq_create_of_mapping);
--
1.7.7
next reply other threads:[~2017-03-13 4:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 5:00 Dongjiu Geng [this message]
2017-03-13 8:58 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489381226-8806-1-git-send-email-gengdongjiu@huawei.com \
--to=gengdongjiu@huawei.com \
--cc=benh@kernel.crashing.org \
--cc=huangshaoyu@huawei.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhanghaibin7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®