From: <Meng.Li@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: <peterhuewe@gmx.de>, <tpmdd@selhorst.net>,
<jarkko.sakkinen@linux.intel.com>,
<jgunthorpe@obsidianresearch.com>,
<tpmdd-devel@lists.sourceforge.net>
Subject: [PATCH] tpm: Add sysfs interface to show TPM family version
Date: Mon, 13 Mar 2017 17:20:17 +0800 [thread overview]
Message-ID: <1489396817-24855-1-git-send-email-Meng.Li@windriver.com> (raw)
From: Limeng <Meng.Li@windriver.com>
So far, there is not a sysfs interface for user space code to
check the TPM family version(TPM1.x or TPM2). So, add a
file named description in /sys/class/tpm/tpmX/ to show it.
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
drivers/char/tpm/tpm-chip.c | 70 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index c406343..b222421 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -36,6 +36,68 @@
dev_t tpm_devt;
/**
+ * show_description - sysfs interface for checking current TPM hardware version.
+ * @dev: pointer to tpm chip device
+ * @attr: unused
+ * @buf: char buffer to be filled with TPM hardware version info
+ *
+ * Provides sysfs interface for showing current TPM hardware version.
+ */
+static ssize_t show_description(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,struct tpm_chip,dev);
+ int ret;
+
+ if (chip->flags & TPM_CHIP_FLAG_TPM2)
+ ret = sprintf(buf, "TPM 2.0");
+ else
+ ret = sprintf(buf, "TPM 1.x");
+
+ return ret;
+}
+
+static struct device_attribute tpm_attrs[] = {
+ __ATTR(description, S_IRUGO, show_description, NULL),
+};
+
+/**
+ * tpm_create_sysfs - Create tpm sysfs interface.
+ * @dev: pointer to tpm chip device
+ *
+ * Create sysfs interface for checking current TPM hardware version.
+ */
+static int tpm_create_sysfs(struct device *dev)
+{
+ int r, t;
+
+ for (t = 0; t < ARRAY_SIZE(tpm_attrs); t++) {
+ r = device_create_file(dev, &tpm_attrs[t]);
+ if (r) {
+ dev_err(dev, "failed to create sysfs file\n");
+ return r;
+ }
+ }
+
+ return 0;
+}
+
+/**
+ * tpm_remove_sysfs - Remove tpm sysfs interface.
+ * @dev: pointer to tpm chip device
+ *
+ * Remove sysfs interface for checking current TPM hardware version.
+ */
+static void tpm_remove_sysfs(struct device *dev)
+{
+ int t;
+
+ for (t = 0; t < ARRAY_SIZE(tpm_attrs); t++) {
+ device_remove_file(dev, &tpm_attrs[t]);
+ }
+}
+
+/**
* tpm_try_get_ops() - Get a ref to the tpm_chip
* @chip: Chip to ref
*
@@ -363,6 +425,13 @@ int tpm_chip_register(struct tpm_chip *chip)
return rc;
}
+ rc = tpm_create_sysfs(&chip->dev);
+ if (rc) {
+ tpm_del_legacy_sysfs(chip);
+ tpm_chip_unregister(chip);
+ return rc;
+ }
+
return 0;
}
EXPORT_SYMBOL_GPL(tpm_chip_register);
@@ -382,6 +451,7 @@ int tpm_chip_register(struct tpm_chip *chip)
*/
void tpm_chip_unregister(struct tpm_chip *chip)
{
+ tpm_remove_sysfs(&chip->dev);
tpm_del_legacy_sysfs(chip);
tpm_bios_log_teardown(chip);
tpm_del_char_device(chip);
--
1.7.9.5
next reply other threads:[~2017-03-13 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 9:20 Meng.Li [this message]
2017-03-13 11:54 ` Jarkko Sakkinen
2017-03-13 12:54 ` Li, Meng
2017-03-13 14:31 ` [tpmdd-devel] " Andrew Lunn
2017-03-13 14:59 ` Jarkko Sakkinen
2017-03-13 16:55 ` Jason Gunthorpe
2017-03-13 18:35 ` Jarkko Sakkinen
2017-03-13 18:46 ` [tpmdd-devel] " James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489396817-24855-1-git-send-email-Meng.Li@windriver.com \
--to=meng.li@windriver.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome