From: Milian Wolff <milian.wolff@kdab.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com
Subject: Re: [PATCH v4 0/5] perf report: Show inline stack
Date: Tue, 14 Mar 2017 13:59:55 +0100 [thread overview]
Message-ID: <148956608.Gr0Z3zOxTt@milian-kdab2> (raw)
In-Reply-To: <1488537785-10684-1-git-send-email-yao.jin@linux.intel.com>
On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
> v4: Remove the options "--inline-line" and "--inline-name". Just use
> a new option "--inline" to print the inline function information.
> The policy is if the inline function name can be resolved then
> print the name in priority. If the name can't be resolved, then
> print the source line number.
This is still wrong from a usability POV. I may want to see the file/line for
entry that have a name. And actually, there are afaik no situations where you
could have a file/line but not a symbol name.
Again, why don't you align this with the other non-inlined frames, and honor
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).
Bye
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
next prev parent reply other threads:[~2017-03-15 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 10:43 Jin Yao
2017-03-03 10:43 ` [PATCH v4 1/5] perf report: Refactor common code in srcline.c Jin Yao
2017-03-03 10:43 ` [PATCH v4 2/5] perf report: Find the inline stack for a given address Jin Yao
2017-03-03 10:43 ` [PATCH v4 3/5] perf report: Create new inline option Jin Yao
2017-03-03 10:43 ` [PATCH v4 4/5] perf report: Show inline stack in stdio mode Jin Yao
2017-03-03 10:43 ` [PATCH v4 5/5] perf report: Show inline stack in browser mode Jin Yao
2017-03-14 1:16 ` [PATCH v4 0/5] perf report: Show inline stack Jin, Yao
2017-03-14 12:59 ` Milian Wolff [this message]
2017-03-16 13:47 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148956608.Gr0Z3zOxTt@milian-kdab2 \
--to=milian.wolff@kdab.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®