From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbdCOJKC (ORCPT ); Wed, 15 Mar 2017 05:10:02 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35360 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdCOJKA (ORCPT ); Wed, 15 Mar 2017 05:10:00 -0400 From: mshan X-Google-Original-From: mshan To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, educha997@gmail.com, mohsinshan1k@gmail.com Subject: [PATCH] Staging: goldfish: use __func__ instead of embedded function names Date: Wed, 15 Mar 2017 02:09:52 -0700 Message-Id: <1489568992-2495-1-git-send-email-mohsinshan1k@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Embedded function names are less appropriate to use when refactoring, can cause function renaming. Prefer the use of "%s", __func__ to embedded function names Signed-off-by: Mohsin Shan --- drivers/staging/goldfish/goldfish_nand.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 76d60ee..8f92ff4 100644 --- a/drivers/staging/goldfish/goldfish_nand.c +++ b/drivers/staging/goldfish/goldfish_nand.c @@ -114,8 +114,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) len = len / mtd->writesize * (mtd->writesize + mtd->oobsize); if (goldfish_nand_cmd(mtd, NAND_CMD_ERASE, ofs, len, NULL) != len) { - pr_err("goldfish_nand_erase: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EIO; } @@ -125,8 +125,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) return 0; invalid_arg: - pr_err("goldfish_nand_erase: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EINVAL; } @@ -254,8 +254,8 @@ static int goldfish_nand_block_isbad(struct mtd_info *mtd, loff_t ofs) return goldfish_nand_cmd(mtd, NAND_CMD_BLOCK_BAD_GET, ofs, 0, NULL); invalid_arg: - pr_err("goldfish_nand_block_isbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } @@ -277,8 +277,8 @@ static int goldfish_nand_block_markbad(struct mtd_info *mtd, loff_t ofs) return 0; invalid_arg: - pr_err("goldfish_nand_block_markbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } -- 2.7.4