From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781AbdCONw3 (ORCPT ); Wed, 15 Mar 2017 09:52:29 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:16386 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbdCONvp (ORCPT ); Wed, 15 Mar 2017 09:51:45 -0400 From: Roger Quadros To: , CC: , , , , Roger Quadros Subject: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts Date: Wed, 15 Mar 2017 15:51:27 +0200 Message-ID: <1489585887-8683-1-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") phy_suspend() doesn't get called as part of phy_stop() for PHYs using interrupts because the phy state machine is never triggered after a phy_stop(). Explicitly trigger the PHY state machine so that it can see the new PHY state (HALTED) and suspend the PHY. Signed-off-by: Roger Quadros --- drivers/net/phy/phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 1be69d8..8fef03b 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -903,6 +903,7 @@ void phy_stop(struct phy_device *phydev) * of rtnl_lock(), but PHY_HALTED shall guarantee phy_change() * will not reenable interrupts. */ + phy_trigger_machine(phydev, true); } EXPORT_SYMBOL(phy_stop); -- 2.7.4