From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1B845FFA2 for ; Wed, 29 Jul 2026 16:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785343923; cv=none; b=fMlqLu3CYpKjdj3uz56hQNT9vR3lk6cS2b2ziDyFclHs/DVbs4sNgxF5uNGhAx+mCrZ0ShtqswUPDUY3/Nni5wGEjiD+PmYnfoA+RLCNtCQjUkaJpN3DAakZStUgouyCFK1loGed3zcmR61+0UztcB+3P7CSIiC79DnA2lCCU9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785343923; c=relaxed/simple; bh=0ZcKYC6CqCOE778Klu3EdkP+RTdCnMbliRZDv81Ibc0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U54lIG+KYNsDsTZKKADsx+8cg2OY2bbRe0DcfwouIuK65pTbrMUxtJhnVrIn/cSFonA9xpJJuEp6xEm408G65IVOBf40lEhcRc51qOhcpBhvvmv2nrA8pPKOr6vUHy/1guLoZRjY0xVC3zNoAi1YXsahrtA3s2T+6NCgqK0dAlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FvLiY0mn; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FvLiY0mn" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84e0688b859so802202b3a.0 for ; Wed, 29 Jul 2026 09:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785343921; x=1785948721; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ynliW8RV51DVn6/Hi9bIDwJycFbIH0QxQmXIx2aXoNg=; b=FvLiY0mnd3rhri34fK4F8q8lUhjLUjswYm4I7+fdRsFtCVGjWDnyCH1hL494EltLSd 1Si8cn4tEA5jMs+MVXgsYaPeOBQQlKqe+lcrpTRBDQjng+yrPAyb2Z2WkptmwD417he/ 910iuLVp2zBed+g0F0NPP0x1/51zqRkhqSARKNDhP7MDe8XKg41CBm3fRhVQFt79vwzP VGf8b6+KyxLJteym+ZXaElqkqtw2CBuYTORt3xfr46Qx0QOR5elQF8jjEywRdQ/2UhAf ckvRAuAH5h4OGppM9onIJD+jwD11pBIrBVNxjsMJdmUyl1YzYlVYndxFNbQ79hMNmbT6 F4MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785343921; x=1785948721; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ynliW8RV51DVn6/Hi9bIDwJycFbIH0QxQmXIx2aXoNg=; b=bjBPEOUbcFGrLceKz8cuVGzsLGWH1vz4U8VQQQlOS1CWqAW6XcwcIN3pXfY7XSq9Pi 8vIst3lCA5ele7EM/uEklnmz9smOICzlnnNw8nEkZS9sAUjBUKrRejldhBWygXexrgn9 hYFVttUdF+psAVZvjN86T+ze4jBgquqb9rBPtdehYZ+ScVQ6uFdh6a9MT9LyKKgvubQe MYkfiuVGFO4+n0WJznJgeOQlDOBnPxjMJ8dmxEWCNyY6DCwGKmvr/d754BSfxebKMgDR 7kp1sf6+ZegiR9WkJNNDtN1O4j4iYlVFuM4wU4r1+9REWpjR1AEX/GdScmQUJ9GOfDb5 Zfjg== X-Forwarded-Encrypted: i=1; AHgh+Rqp+0lGz+jYuD2wrrKyBmhRSYhfjuz9127wN7tf483iw+PajChq9WStcFf4cgp4E4ZH7RDZEOU1y635b7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzVHNWGcyVewzTh9zK8/JhVoDsJVgpQh4vhJOLV3su19fCJuA4o PUMJIIoDONNZFEjDabLvceaj4D/G5AVn0WTtZcbaNsyGBMphc60JyrtX X-Gm-Gg: AR+sD10y143s1nBZCrqwWk1LP+WViJeJjLl64Gm7XYH8yM6dq94Ifv8SwA+C95+fGA1 KhZ14IPkW1Kp2bw/tLmMebl60Lx5gBS+OurSg2jYnAA6NVnjgljFfipeqtgVmHZjlxCpWxu++dK BbdB+uX2cS7DLBhKQjIy7nWZKaPbZ6uRoCn1d3Qx1bRJWe6bq69jmdtqb/t0miiZh1cPEoWqi93 yHcysuY9GJzkV7XCMPCbU7rgl+zmzggQnpNub5+svZ9qjzXsi6nFPnarFu0Km0FufEejO75T81A xyeC4rVzMDNLlWDLYA7KDo7yDPs583SmoxyWXySc+qGvsRGQwKTTBjk+VPGqnH1R/ar2hP8NR8U 3uBl73bCmFQ76C84Y0TFUhw83+R26pPUIolTLHNtwEaYAR77qWqou2TMWa+kYa16l/dy81BWSVU CAiatbbtpYAiHAX31lanUM1xM2aHvAtV4j4Ry77lF2gZz/6Ki8HKMGV8ywG9VyUwDcE9wy7uPCY mYVZzxcSRbLP0ol87/TnkKDxMc6ZdvrmFwU5SgH X-Received: by 2002:a05:6a00:a86:b0:848:31fb:43d9 with SMTP id d2e1a72fcca58-84e9332e820mr7983253b3a.45.1785343920946; Wed, 29 Jul 2026 09:52:00 -0700 (PDT) Received: from ?IPV6:2406:3003:2007:2131:923:11ce:1cdb:19d4? ([2406:3003:2007:2131:923:11ce:1cdb:19d4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e9fe1d07dsm1697570b3a.8.2026.07.29.09.51.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 09:52:00 -0700 (PDT) Message-ID: <148e56ec-dc26-4be2-a7af-eb547b517a68@gmail.com> Date: Thu, 30 Jul 2026 00:51:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout To: Michal Luczaj , Stefano Garzarella Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <95cd0d4e-58c9-44ab-b94f-fcf57b88583b@rbox.co> <27412e44-ab4b-4dd3-9685-481875683860@gmail.com> <6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com> Content-Language: en-US From: Phi Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/2026 11:49 PM, Michal Luczaj wrote: > On 7/29/26 15:29, Stefano Garzarella wrote: >> >> This is a good point! >> >> So we still need to remove `sk_err` check in vsock_accept(), or set >> `sk->sk_err = 0` in vsock_listen() to have a complete fix, right? > > Yup, that's my understanding as well. > > That said, I'm not against flushing sk_err on a failed blocking connect() > (this patch) as a follow up, if you guys agree that makes vsock behave like > other socket families. IMO, we should remove the sk_err check in vsock_accept() and invoke sock_error() in vsock_connnect() Thanks, Phi