From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932241AbdCTU2a (ORCPT ); Mon, 20 Mar 2017 16:28:30 -0400 Received: from mail-cys01nam02on0054.outbound.protection.outlook.com ([104.47.37.54]:48460 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932230AbdCTU2Y (ORCPT ); Mon, 20 Mar 2017 16:28:24 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Yazen Ghannam To: CC: Yazen Ghannam , Tony Luck , Borislav Petkov , , Subject: [PATCH v2 1/4] EDAC,mce_amd: Find node ID on SMCA systems using generic methods Date: Mon, 20 Mar 2017 15:26:51 -0500 Message-ID: <1490041614-90057-2-git-send-email-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490041614-90057-1-git-send-email-Yazen.Ghannam@amd.com> References: <1490041614-90057-1-git-send-email-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR12CA0029.namprd12.prod.outlook.com (10.175.82.143) To MWHPR1201MB0142.namprd12.prod.outlook.com (10.174.98.145) X-MS-Office365-Filtering-Correlation-Id: 01d9d574-8395-48e7-39bb-08d46fcf7927 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:MWHPR1201MB0142; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0142;3:pTb2TKsPP48i7We9x1zxCHHrTAkFA3HMXSElsE06sBhF2lGityBKRG3eVWXUziJi/8JNyPZz6Hy0g5BMq/PIIosgy79dq/9/jWy2nd6782wwiloIidnXvhXsWajOqTVhfQv/vC6VXcLVdiKcFTvDQPJp4ZRHoApNIsmAQIEtPEHnG9NpzBbvK+vVe/3+4nSIg+3B3EidvRIL6rSuef9uPlMQa36cIIq7Cw45H1jNloeT71jvJAE/q5RkaCAQ3SIIz1gKgv0C+fqOjB7j3IrgmqX3bZ+CpVhaDRMNLCLyp08=;25:YmCm/kw4YXyVus65+tDhg544+w9D1c0UlSJVUJQP0+qeh2k7Giw37N/O4GnkSY8Tfavw08ba4Vy5kwXhE35jw+q25jFzJ53gbbUYn8nx2f0na1AcDb3/HzpVgtalIDXqWa7BWh6u1Gm+Uz5MFN6q0XcKyLCp/rj+HNStTMWGupugKt2c8VknJLpag5I55yvm699HbcPr9wNQyGOi7yxWE3o+uO5ai2w3+4hcdwQ6NU35dYZhIK+bXKl209bwdiWddNw1DzBSY8supZyFchtiibnUODVUM+h9HYlKzxivNi6c5RPYpWIRr6f/cZxIt4HNB6Mo/l+SD+ti1pQ1DEoDVsfmQlYsl3Fzi8Bvk6MUJP3RqWYew/txxv/nG8cH8K8KIwbuk6ZNqTp7sh2Q2w0QFbGZ+qfQ6XSH3cW41jg8gUIsoFka+ZD//33VOKg7HhvXzxFPB255n0oRacnRnM2HXQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0142;31:AO4GhkRxVJPOLirRQWQN2viCB5YmlvVkfayAPUBl+sy3lcXIQH7MTEhNo2RZIIIUnNF7plSuk2kSSacHrlllQr9rHjT96+DuK+kVgNY9/urXYq7caWAjJLdcj4uENefDq0nVUpGA1iyYnUeAGDUvIJVbvqPxBQuPANpExW8HswS5P6twBlC1ajHoLXNWsrNZMyiSWZcmCHpbTPx2cgtxhr0US1PfGynR1bQdmCRbD3Y=;20:j8wy/89OiHfoYCjn4DRhH1RrF0lPkhl0zs3Y6ZIX8L34LI6+K9VanAOuPxdbIXwJq5N0wk94RqHz0KA4Kkhp6Wk+VxTmlEBRGfbSewYeC4RU8UAgNq4ZAlNIR/seH2oh0HPAMJRnsIm17uD3PXvFEDfojljs5grX++uXk7GgLA5L14jBQyz2XmLTtXltVXlLDDGA7rmNfx9Y+Gw//ILwHuCzVp9RC02pLn+9v5vE7BJ/5nxm32f83CJxOjg5KlSfaqMZA8DPWAu+RKD+D+JxibyiGYJWiaNAYAtE8faHJNrTYwQI8/NzXBuV1JLefiMt7wmbtrrmrK26deWrMKBmRjutaqSSu/MUVasEUDmU/E5ZW+gN65NZiJbQx9s1Z6JmNPomvciG5KapPOj2UJbxme3fDCTB0iIPC8bxfPxMlDGtDribMwgILFEakJN4qzWZX5FLFvXAg/oym9PaFcs8BYLkGhST7pXSyAzmQoe+sIkUzbJzCImD8uNqs7f6MJrs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(788757137089)(42068640409301); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558025)(20161123562025)(20161123555025)(20161123564025)(6072148);SRVR:MWHPR1201MB0142;BCL:0;PCL:0;RULEID:;SRVR:MWHPR1201MB0142; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0142;4:+mW1WSYfMDKeCofERfBCDCkKkAdQsAA17WTs4MF99VtxQPF5yOyiq0u+2bZOTyTltBtiMXB4rlE1d8OiYouiQNpgC7rEJnNi4JAkpYL43ZaL2bn2YwyrXBbOeI+2bIiZ3zqJbhvAnT/VyYKpB+gMLUx+8KTNXxDfXiS51hUp9GZKr+dxXz6dO85td+lwF0ZLM2smVhRUEMWazoDTuT2zb+1REoLVWz/dbUYWK72HLs9W+xLwyRgcl0x+t2o33qlo28kle8qW6UktRPxh+Lcg4Wk2EnJjjJeLKRCxY7bJgBSLETRv/c8IE4RrnhfnBFAzi/5IBGQW14S/8w2WkQ3ZWsAwjTxm+U0ka1Gt+sAec1IK3bBz/NcMrOtHgPDgSH0vVcJxlpU5S4/d07Z4egF16JUEYDSiJHQRsQsxk/fYg5a8qi2nNC2jYmsTLZiCiUK9WKrfen1ZM3CcUZAubK6eRwqlrYfp34AN4Qx2kaCftZ22Vpvck2TIxLxmNQ7s14BE7V58uJMg3JY1MYKbvrjCYWhldvazEfjS7UvatHGm/GQhI4spy8ki/QiNrCtdLOQ9h3Kw01xi+z54GVGM/EtifzOd3hVf+WlASYRtMcCks+vnGoNu2SRYKIgnO1+diFFEorDvPO+EAk4S4qeQsxJqj+9AIGKDXGbJtKBn8eOERGr3faoPHTzbyEbRlwaYX4DnR0OC19w3xOYnwrnDUeyQLX6nbHAw54n9KkxdM2N4zvI= X-Forefront-PRVS: 02524402D6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39410400002)(39860400002)(39840400002)(39450400003)(189998001)(53936002)(36756003)(81166006)(6306002)(54906002)(86362001)(38730400002)(5003940100001)(66066001)(7736002)(6916009)(25786008)(76176999)(2351001)(2906002)(50986999)(2950100002)(48376002)(4326008)(8676002)(966004)(305945005)(6486002)(47776003)(53416004)(5660300001)(6666003)(50226002)(3846002)(6116002)(50466002)(42186005)(110136004)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR1201MB0142;H:yaz-diesel.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR1201MB0142;23:ApCuZKtOB6UJUxuM0wJmCP7y95iU4gCU/GGDhGP?= =?us-ascii?Q?lpFO7y/6nEHXE8GUmQMk8NcLEXWCvhaoauV2MPWhI7VVJ0ukGM5N5qtROOVZ?= =?us-ascii?Q?+OhTf6xNlaXyLzw9aEQjm2YsHHwFiJBzM4JSe+pw3juNSsJKVXk7/GpjBEAO?= =?us-ascii?Q?EP5sN6YUtmeErFtl7NNe9yPfOe/4hIzO1dr9xKmaVb6uZZv69dw1K1YDKexC?= =?us-ascii?Q?eS6TmbGyTsmU3BUP7ctMYBw4f7pd/wCXQkq2wV9YDNT3xy68XVgKhtTykT69?= =?us-ascii?Q?cmo0oXaZItYdXchPwNWWcacTnH+LRCPiEYN5OYYh2gTByzqCbQdUtzpg8glV?= =?us-ascii?Q?pFq4JHWdvjemoY//IMVdyfv1ICQBgbSnLpd/H1z6Km6O+JCTeBZokKFzUys9?= =?us-ascii?Q?OrMs9wVoxFPVW7caIU+m2pqD84KzA1xd7MkHgqpQRHfY96lWYd5nkXcv+Hsv?= =?us-ascii?Q?cZL8sxdsNOWfMy4zOC5bpj6K4HAHARbD9nIr81eZBMFT57+CIypPfTmYESJo?= =?us-ascii?Q?4BwnXFM8q6/eIBwLvTQA6DWHdsA+hFdsWqFTtOPAnhsyt6edcH9DWy4wmTY4?= =?us-ascii?Q?EmqOz0rL3s/ypMT0xKw3sBKMMWNBtypeCly7qUAZs94sBwYbXeEUrGQ+v3wY?= =?us-ascii?Q?oru/W+K9B/fbkvLyZeyboiLuxy1dp2irX6YPDiu7Al/ROfySYhX/M9bFo0c5?= =?us-ascii?Q?+yek7Z+ED4lXRXAbR5RYXZiWTYPGHHM9wECnrXmnwy9JqWUzOAeMuJyIfZ0q?= =?us-ascii?Q?q8/AyXE2yYHbb8EOpU9V+O2CgDCfyTsLh2llyblHRtkg91SNr6X49rJ47aEB?= =?us-ascii?Q?4F6bKbuHExd7eUW4JZDMENA84F0qgTCL+/BmwI7kR5QSK63NLOKWGxR7axTc?= =?us-ascii?Q?iWf9HpCJlYw0ioC4nEgbP5uiRl919pUcGdHsCluaXeaOlANamsJrQOzRnqSj?= =?us-ascii?Q?aLAKCDpmlhM1tznsIz4zL26YmA2WyKq1Lppp4r5D8Av94Ra4YlEQNbPQxfUy?= =?us-ascii?Q?Hs6DXirHvBUkFWMoscDCDnNKmKqo+uyEWjmJ72KP/h1reRD8JJtlsgZ73jGh?= =?us-ascii?Q?dT6g30As=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0142;6:/bVgT7fvgK7OdnmpBBRypDvRfB9FfgQtRp6F6FbFS5cH5+w3vNLCZuVF2uZhzuJoN5Gx81VoV/K25MTjO9Hzi8wPVJZfhUagcoczf37ziWAlAnPGOmB97C8SuzfJkg6hTTOlC1axCuYnWBFkYhDIHZyB+2+XSS9BAZ/mFxLXljy9RiPyHTXcb9QxQ4BGoQenYK9BH8N8flwODUSEG0cBPK25gVab6iFswIEVNNZG9+mD/QLnGAuJxo3GdVk4FwLS+dUC82HVKZx0o7zu+GPT1Y+oY4Ewd0ZFlzgsLJ9vGb9MNmpP8ilpx+5xpu/Ax1Gxuht48G19svQE1AisC+PTUgQU5sZybZkkLweYQxqPO9XX933UmSpNRReb4OzrLygPGNs3mfbK6qWETEGITDszV1mbfIDM63yOwthZe5F5Xio=;5:KcR+Ys1Jwct8rHxnUBq9rchUpESx2bwoS4iRh0ISFb5+EZnlIhdkJTK46C9RSanXqS44l3UO2Mag4plere5n3yEDtTP0djbYv49EfWU4mOj8KJ1MzHBCOUZfsNYLIf0JkLWyR24ErlqsaBSYjIZPZw==;24:wnwMwqdx34rF2UK5kcCI8WvQeL+x9/Qvxjh5o0tKjEVEOcvXT6YhZChqbj5Vujlcw6efmB6gbRc/kB8Ec0Ljf8BNtCin1+KoUJu0+XOFCRk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0142;7:seIeWE3w21jAJF+J9ca5DjvdXWZfQDI4Wbo1wiSrPvf/CZe5bDz1v6+7RbU1rVMcQoro0TtqzroRankSGBD7AkA4DUcM2pVsx/XnrY/P2aO2CC+iMYDLhGC0nJTwuZ0gAAuwEZ8dzSQeufYd5sn1prw0pxECx4vpCF4YubsktZWqZhFdbSnLtbfPsMjGyMvLdymfK4wa4eEF/fXDAYsapnhFchImbpwHo0mIXkX6u/ByzUIIEDu1hI5FLXQBlGtWlT+CM50k3VJKMMqiJZPY5tss42m4vssMbWZqVU3177R2kM2cqdLY/DfDu/B2kQwyXKSdDj5FtrBx48+r6gaabQ==;20:qBvjLxdfM+ZfRzQwGL25x+4YkTuWO3qeTsr0BB/MaRYG2/VTXv5nl39EjGSc+04FWQSwJYNXkenkt5gKyQCJm/IVZcb+2mNdWe0DHIp/IuMwxpxDrDFcGyyuNxWhnZfZTrbZ48x3V/EEMbij0mheNEVRYcpU5kvl1+hGeYHd/iSzrFC9gmxHtQFXxnw+hW7OcasU30B1mO4PApQevl6IImOnkZ0EOmiZawlr1pj1sjUTbB8s9I9pdoebUTfAybf4 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2017 20:27:04.2955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam We should move away from using AMD-specific amd_get_nb_id() to find a node ID and move toward using generic Linux methods. We can use cpu_to_node() since NUMA should be working as expected on newly released Fam17h systems. Replace call to amd_get_nb_id() and related shifting by a call to cpu_to_node() which works as expected. Signed-off-by: Yazen Ghannam --- Link: http://lkml.kernel.org/r/1486760120-60944-1-git-send-email-Yazen.Ghannam@amd.com v1->v2: - Just use cpu_to_node() instead of trying to make amd_get_nb_id() work. drivers/edac/mce_amd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c index ba35b7e..dbccf40 100644 --- a/drivers/edac/mce_amd.c +++ b/drivers/edac/mce_amd.c @@ -878,12 +878,8 @@ static void decode_smca_errors(struct mce *m) pr_cont("%s.\n", smca_mce_descs[bank_type].descs[xec]); } - /* - * amd_get_nb_id() returns the last level cache id. - * The last level cache on Fam17h is 1 level below the node. - */ if (bank_type == SMCA_UMC && xec == 0 && decode_dram_ecc) - decode_dram_ecc(amd_get_nb_id(m->extcpu) >> 1, m); + decode_dram_ecc(cpu_to_node(m->extcpu), m); } static inline void amd_decode_err_code(u16 ec) -- 2.7.4