From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbdCUNSh (ORCPT ); Tue, 21 Mar 2017 09:18:37 -0400 Received: from mail-sn1nam02on0048.outbound.protection.outlook.com ([104.47.36.48]:22620 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751477AbdCUNSf (ORCPT ); Tue, 21 Mar 2017 09:18:35 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Yazen Ghannam To: CC: Yazen Ghannam , Tony Luck , Borislav Petkov , , Subject: [PATCH] x86/mce/AMD: Give a name to MCA bank 3 to use with legacy MSRs Date: Tue, 21 Mar 2017 08:18:05 -0500 Message-ID: <1490102285-3659-1-git-send-email-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR12CA0047.namprd12.prod.outlook.com (10.175.82.161) To MWHPR1201MB0141.namprd12.prod.outlook.com (10.174.98.144) X-MS-Office365-Filtering-Correlation-Id: 024840ac-1f6d-40b1-fdb3-08d4705cba5d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:MWHPR1201MB0141; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0141;3:ujY4P+azV7G0+8pv2xpbcSs0ONfFhqeNy8AuhBbvwhC9qHR/CBFuKQZaPl8D3memIY7IxSHEd1QYmS3/C5kf9C/tEyPoMVAftebGMhh+z5dJYnN/oQAUzejJstFzyp7Qxmq+x9s1hh4aaMUlInurJw/pomKMF7KzAs4FL78CCIdVHmV6F7VG/+Y6/UKpXWWOsncn93DRECA4nEyJGJpOjJGQsgeZuazxJL+6flW3oEJyTudyhDLO2Eqw2bpQxlro4BUBqn7P0EU86wpzIaQZ9fGWc5EUy76ZGK1OvMgS0GY=;25:qim4aJoJOt1QrbdmxObS/t05PViGACIHndFJWR+ou+DYNTB5t/X2XFaw86kapdnKLIwSgGt5MfTeJOKFNI5hxs6nhIvOHCxKms1Y9Ey7Iscnvxs3jByhRMD+gaqMa0vxOvVpXqkN41b8bwzLpRlDPwdWydvhF9ADH96WfgAkxx8sJgx+gkxPaO5ZjBE5P0WyRjV+LFfYyGoAoAzOdnQyeL7KGLdSwit6f2HXERnZSaI6zOt3jcQFARO7UFjU/wL/ziyr30GI6IE+PY4an7t3ssmEC6pWsayYHvmjjL0AlDgvjzZAwW4hD50crUW7QD0Ad2yT74B+pDBiNfScf87bYD9Y2tiUdVJrsVnWnjotvDMJrSpcP2+ie/CbLFfRPubS4tszQejo2jixdIfHt+TuGZ8xKPctMuADG3TbWMjEDOBLO6VgTmGApVojMtdfgRhIyl43qYuq51ii1N9o0oEhRg== X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0141;31:1UI+82jA2/fW22OfbKLiL+Cvhfogx44uRcHJ+8ilmJDTbHkQiN+eFgFlXOGuAVLIKIxptD3L2qjwsjmbKzrXXYvoHnhcmnfIIigd0PimG9QQF8EVvB6obDPVtcxvR8sKg5v++Fc42yYtKGb6Z7Q9Io32mLvSTRVX9aW20Q1UXMIeavEslm8MwMJJORGo4N6dZCwWaz45x6cM5Etm6DfBytPKj/BNKXUVTJ6x1DJhlvUQEF48BK6mp7x1X6KTiAra;20:BOu0voqbfjFdVD1LqL3Rj40rEGeACrj7DZ1vJS7a5O4UjxC6E0o5mU54DdFuvuNir6yk3zKHB5jreiFv3Sw9mZSSu3UpfLfQR/Vb6nsR2ryzwWMCsFdny+q4yx2AcmbaA7ZJEK5I83fZQ6jubS8d5duW1S95VqY7zdLlLHCvYnjGJsFtwJFEoa73TJ2msh0FxH5yjRkW7FyqJOVfOscoNtpCG06c9kePiT9YkVeQxNRQt/LPyKZc5uziwWSvBI6JRw03SA6uS2g1tvDIL9Pps+TrEtC8Yobyffd7WoJICob6ZQU/5QAba7GXU8Jg7MXw1IZU9cp8GGwp1lzUbjcylPr5iJe1vNoqUC8A+2mYFLZS1vi0/Bf09l20FZIFshIajV8Une9foTpkTZWeWpmsvcvjK/NNRFpC9Z1GBF8kfluqiA4MI+uFQ6naEiYCMtDlt8/67U6dxoOD0Bb3fjY1zOicQSUfVeyZBGJR+y+YcdFklWEtrxL6lHftwGzL2GKt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123558025)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148);SRVR:MWHPR1201MB0141;BCL:0;PCL:0;RULEID:;SRVR:MWHPR1201MB0141; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0141;4:6+GFQWnS4reSmjow84heCTCqrCmRJ8Wui18+0tWvHirTZvpsuv4KBsbDv5KJNTZhiHeLUwm94i9xvQePxZVkAkcSdjPe0QoJVVGTVYN6dgGG3uqBp+XS69JKxEee8ste0F2xeoAbg3Z6HgV/21SbfcoE8aN28+ibDuyswU6QV2DjemobwNVFvPcbuagqYL4CTbJmenZIE2Xyg8yu5ZbO3N00QlhUouSASjKhYotYBl/Iq8h23vuSl+fEtLawy2PtxLvDXk4xgul2EUuTt42Lv+Gc1OTRtOd9yJUoM7jWhmIAeavxXsd3eKZSkRoy0obsm7ERjYhutDSmYTjVeIotIXM1z75wso/H8vkk5XKMT9L0ofvuAf4pN29+6PgHSebpYJFdS0s0QENIvR/dcVViVtZW1dkcfxqs/RvNXSPOTr0vVV5/UIjWobDf1dwF4LNDNvnKCmdsT9Se7xpzEt523JMRd+l3rf3i6QudRLx4vc1UHZQcjYMLCBnT1I4gHoaUe4xv3bNruFlO6GxrgkdTMhkfCEWNgDYyQre7wCiihYKDZ2ZrpZnkCXB/SddMmBn+FdFfu2VrNHSM2gY3yWIzdWLU+cPVeTXBA22Ot81b1oOafZk+PMYdWzHe6ZhPwzQjGW5oU1sQN4MByS/BaPRZJPMG3Uu7jrj4gpwAaNJf7cUdnkgPdM3lCq50SwWmxlfa X-Forefront-PRVS: 02530BD3AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39840400002)(39410400002)(39450400003)(39860400002)(39850400002)(81166006)(575784001)(42186005)(2906002)(8676002)(6486002)(4326008)(2351001)(15650500001)(5003940100001)(86362001)(50986999)(25786008)(7736002)(50226002)(48376002)(5660300001)(305945005)(6666003)(36756003)(6916009)(3846002)(66066001)(50466002)(189998001)(54906002)(53936002)(38730400002)(110136004)(53416004)(6116002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR1201MB0141;H:yaz-diesel.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR1201MB0141;23:82YBVtskUrJXk05+mc75X/0eHtjWp5MEJeJcAt3?= =?us-ascii?Q?lSywoGLlLXQLfG0UW+ecuVq/1ALzLblv5j3pN4k0lIZVux7vNsxwOUNhCbY9?= =?us-ascii?Q?lZIuheT5KBDLAOKcGz+pHaeToomXyeN6ju4/IVrrxIbfH6zTtFvRE2fZfnz/?= =?us-ascii?Q?78fKl+yMqGI5NUKNWwctTHKK23AURqk+rEvMLRBjA+4VNnQlsyqRLKJQxNNp?= =?us-ascii?Q?n40rRew04+L+/xyoiwByeIz7xjfBNDMUVfyCnTiwiDhXmlmPuHud3Inc1J7G?= =?us-ascii?Q?oneCFVYZa+zkvWO+vUs0Jc5CyWqKCMmavZmZs3q8NC3ZmN9JieI31N6ZlV6B?= =?us-ascii?Q?fQdgnScegaJ9NtVTsW79aFiNd3rcs/bjhEGe7AGlaNopn/pMRrwGtduZq2nR?= =?us-ascii?Q?y8rfDFCcEGhdlUIYcVPT+55qafhtEUA6Dt5sFCu2XNP2fEhFPKn1HqqzwOYI?= =?us-ascii?Q?V8TySZzTF08piLBQfk3HGheZy4FoT+qifUdeYYXfaH7F79e4ovJfcSAgZFt3?= =?us-ascii?Q?OJk30XToRlB3dyFzTGuPuokLDQb8MWxjI4Quen7IHscoV6kWZsLD8XyPD5MV?= =?us-ascii?Q?3nan1TmrxSZpYNFwszvDdYLjks95O1MGyv8zRv8gQn1gbwE5h+/FQqvlJ8ZE?= =?us-ascii?Q?nnq/qIsZObh4H3iyHsNbo/jZt/loY8nCDeMoSfvtTADBA+URNLcLRElXWLGV?= =?us-ascii?Q?cAyiQ4B01f636egiJvT2RBJfo5eE3hM2WhrdaY/x378jqT4OoCT3gx9cZ6hc?= =?us-ascii?Q?thU1ys1eT+3lkbPk719a0fCByVNTgjxKcDK1os/8rHKgq3M3vF/3yXh8HdTW?= =?us-ascii?Q?d4H/4oaYWWN0AKybU8LGBkfUS/ie9J9+s1JwPXmPAu5vez/5ONlS7r3CZMXe?= =?us-ascii?Q?Ja3e+ff8d3Y6UHXtCpSai2lcksPTBi2MUZCsWDr8auedb8xPj5Yt/aSdSegc?= =?us-ascii?Q?9fML4W5tSQupCnzkixn3u0hv/ug2Kz7kwle23wP2Lg6SgNUwLls6y5Vd16Dq?= =?us-ascii?Q?OIPNKQBq9hXSj8uxY99fhDd9/?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0141;6:F3o5wgX2nhKL6ea3/h/pIC1Yh/mMzZsHI8JOPvGfWzOA1YMV1jSm022DwZ5cmc/Iem7U2euxN8iWD7skLDGyhZQvZoEK+JI7qgQHxck8PXnUMsTn6BVOqLSkbQAq5yVT6XxwnTJMQhKWPWUns36kv3g1Gh9Ji1JKDZazJoudo/FWVHwxTOeETyTihomgKeXqBOy9yfZmF3Fi1MeXY0YqObVru2M30HMltUjICSNy3f+VBKzmjhQAoADuk/xVr/An5nzpBVU8kOqhih6z38HyFZqQO4OpAMnyCdS4DgZVJmJnElDDNCv1/GS8+pWYwL8nwNsdKydbndqQxZnCgzgF5EBbES2IJvUQxbxVtxGpu/pDVHuEUXnTCrqyiShUgHhM8bb9myC2Tp6BoSFJ74kSdFcinlLDlSsXh9vm/CmVcSY=;5:BRyiP4vbdUtWRycIMblPuVNpeejA3hCtQufh7GFWbcgyuwZmpFwNOH38LYTn/lr7gWTiXHUfd+I7g5IzC2DRF9imFh6Xr6FGNTEKhr/VWA77+KEQh976w+KqFI6ERSSPJB6cog7Z2hqaCwtiUmppAQ==;24:mNTfJcS3RWl6yuIqXP64hahHbS5qTBW8rZ+avxdcS4OLbrsyv/pbY8An//vpith6EpTNXulZVlkJeG9gizDyGasY37116Chw7ypUoT2V2fY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0141;7:uFJCyN6+VrdXPgz0SpR9jgUbTWrIzJ/S+XHpjRSiU+KnPpCTWYwVuV6aCuFwu9wZR4wIIG3snAQar6OJIQnk2sZSkRSGjvzp/2+J0rAlp2HioDRqTRBukw7AQWoCSa5D6F4BnIDBbas7PHxNRRl3kjFCN+apNu1NobUpkBRpbV7g4Q13mZ4xhZjcJdWToWTP2GDJvQ52ukAY5wDeLfkyi2s5d7AkwRCFbjUVb7Xy2nwLy+GVGv3i3Uw2d4Bfc9huIY6YtayqSKYyWLWMvvKKFEyOcbd5MP5v1ie4IPxMPcHPle1kPcwXEeBA98ekWxqwpMpWqT1G+uXrOYgnXDDyXw==;20:u5LKoOq2xNSw0pFTd9bKWM7z2VFDiULzsxuVZU4qWzR4KvmuvR9xAGOGy6U4SN7qEf4xQr6Le1/uaGaVIfkpTtkbGEI/rFvNJIXyZgDl5HITWdQbXz+GAVhs+xo5E4U+nziSM7cSg1AomZ96Y1YCFFRRQ4wCYQBmIAIbQJMo4rG9vyXwxrD5/heNwW2DrA9P1rxz0G2Ec5bFad6k6wa9yEpBWQ+eec5bbZQtLmqutpXceAppCDWiyO86rTA9yWY+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2017 13:18:12.7462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam MCA bank 3 is reserved on systems pre-Fam17h, so it didn't have a name. However, MCA bank 3 is defined on Fam17h systems and can be accessed using legacy MSRs. Without a name we get a stack trace on Fam17h systems when trying to register sysfs files for bank 3 on kernels that don't recognize Scalable MCA. Call MCA bank 3 "decode_unit" since this is what it represents on Fam17h. This will allow kernels without SMCA support to see this bank on Fam17h+ and prevent the stack trace. This will not affect older systems since this bank is reserved on them, i.e. it'll be ignored. Tested on AMD Fam15h and Fam17h systems. WARNING: CPU: 26 PID: 1 at lib/kobject.c:210 kobject_add_internal+0x23e/0x340() kobject: (ffff88085bb256c0): attempted to be registered with empty name! ... Call Trace: [] dump_stack+0x63/0x90 [] warn_slowpath_common+0x86/0xc0 [] warn_slowpath_fmt+0x4c/0x50 [] ? kobject_add_internal+0x18e/0x340 [] ? kfree_const+0x22/0x30 [] kobject_add_internal+0x23e/0x340 [] ? kfree_const+0x22/0x30 [] kobject_add+0x68/0xb0 [] kobject_create_and_add+0x33/0x70 [] threshold_create_device+0x107/0x350 [] ? mcheck_vendor_init_severity+0x1a/0x1a [] threshold_init_device+0x35/0x4d [] do_one_initcall+0xb3/0x1d0 [] kernel_init_freeable+0x163/0x1f0 [] ? rest_init+0x80/0x80 [] kernel_init+0xe/0xe0 [] ret_from_fork+0x3f/0x70 [] ? rest_init+0x80/0x80 Signed-off-by: Yazen Ghannam Cc: # 3.10.. --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index d3e5be8..c82befc 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -62,7 +62,7 @@ static const char * const th_names[] = { "load_store", "insn_fetch", "combined_unit", - "", + "decode_unit", "northbridge", "execution_unit", }; -- 2.7.4