From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755433AbbAaUW5 (ORCPT ); Sat, 31 Jan 2015 15:22:57 -0500 Received: from mout.gmx.net ([212.227.17.20]:52305 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395AbbAaUWx (ORCPT ); Sat, 31 Jan 2015 15:22:53 -0500 From: Marc Dietrich To: Julian Andres Klode Cc: Greg KH , varsharamt , ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed Date: Sat, 31 Jan 2015 21:22:21 +0100 Message-ID: <1490239.sosRNrUv3O@ax5200p> User-Agent: KMail/4.13.3 (Linux/3.13.0-44-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1422705282-17374-1-git-send-email-varsharamt91@gmail.com> <20150131162913.GA23688@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1450518.CmoNRZ9DjU"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:3fo/t15O3Hk6a26pKYfW99JL0KXAEpbKrfJ5CE7kHq5lo41BYWU 18Qpgsz+LaQHXHK3aiok1oqBw9YInaVV4wCGTDSiDOM6sxsQT8a9MeaEK5SUcni7l+ECB45 MFh/smAJWpQFc5bGZ/9QxfzTXtGqxi4nChm1mK4TVrfCjK+J0mfQI7WjSUTSvG+Qan73mN0 XikBRgo65+7c434+HaYvQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1450518.CmoNRZ9DjU Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode: > On 31 January 2015 at 17:29, Greg KH wrote: > > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > >> The task was to fix a warning which was shown while compiling a driver > >> called NVEC. I wrote a brief description about how to enable support for > >> a nVidya complaint embedded controller. > > > > This makes no sense, what "task"? > > > >> Signed-off-by:Varsha Ram T > > > > Please use proper spaces. > > > > Also, this doesn't match your From: line. And, is this the name you use > > to sign legal documents? > > > >> --- > >> > >> drivers/staging/nvec/Kconfig | 20 ++++++++++---------- > >> 1 file changed, 10 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > >> index 9475e20..a65ad4c 100644 > >> --- a/drivers/staging/nvec/Kconfig > >> +++ b/drivers/staging/nvec/Kconfig > >> @@ -3,33 +3,33 @@ config MFD_NVEC > >> > >> depends on I2C && GPIOLIB && ARCH_TEGRA > >> select MFD_CORE > >> help > >> > >> - Say Y here to enable support for a nVidia compliant embedded > >> - controller. > >> + Say Y to enable support for a nVidia complaint embedded controller. > >> + nVidia complaint embedded controller is used to communicate with > >> EC. > >> + This is done through I2C bus. > >> + The request to the EC can be initiated by triggering a gpio line. > >> + The gpio line is a generic pin on integrated circuit whose input or > >> output pin can be controlled by the user at run time.> > > There's no way this is correct, look at how long your line is. > > I'm not even sure if this level of detail is needed. Why should anyone > that reads the config option care how NVEC is enabled or communicated > with? I didn't received the original mail, but I think this is related to a checkpatch warning which demands at least *three* lines of help text (we only have two). While the sense of such requirement is discussable, blowing up an already complete help text just to avoid a checkpatch warning doesn't make much sense to me. Marc --nextPart1450518.CmoNRZ9DjU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJUzTl9AAoJEKyeR39HFBto1JoH/2ew/ytk63lZWsNEUEKoNVTU 0eazHUPx3/F2o+6Y/XdmM2cqnCqp+SFtEJVX8+f+EYZpX06f56RtQoG6jLaosa0g pAtM2qJoy8MHNOBW3KFPEi8IBjziajWPiOLCa8roxxIe6EYxTQ/H+qTwT/3+foe6 eRaI6C3HlSEceM+hIB6JsMvjfE2e5pF5ib/AotxV4q3CZlnWTC3UNPO5/NnLAAsL R1KoNkpMj5HHna+zMYFmPoD9bNVKhGhbQmFNwflFPo9WaK8J8MnEPU9gKifOr0+q Sz1wMMepPg5sMjlcT7zxRI4//sSdkj28cpfOiM9/izepMap6aUXAxuhIZZQCvGE= =y2nB -----END PGP SIGNATURE----- --nextPart1450518.CmoNRZ9DjU--