From: Zhou Chengming <zhouchengming1@huawei.com>
To: <live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <jpoimboe@redhat.com>, <jeyu@redhat.com>, <jikos@kernel.org>,
<mbenes@suse.cz>, <pmladek@suse.com>, <huawei.libin@huawei.com>,
<zhouchengming1@huawei.com>
Subject: [PATCH] reduce the time of finding symbols for module
Date: Tue, 28 Mar 2017 10:02:15 +0800 [thread overview]
Message-ID: <1490666535-19192-1-git-send-email-zhouchengming1@huawei.com> (raw)
It's reported that the time of insmoding a klp.ko for one of our
out-tree modules is too long.
~ time sudo insmod klp.ko
real 0m23.799s
user 0m0.036s
sys 0m21.256s
Then we found the reason: klp_find_object_symbol() uses the interface
kallsyms_on_each_symbol() even for finding module symbols, so will waste
a lot of time. This patch changes it to use module_kallsyms_on_each_symbol()
for modules symbols.
After we apply this patch, the sys time reduced dramatically.
~ time sudo insmod klp.ko
real 0m1.007s
user 0m0.032s
sys 0m0.924s
Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
---
kernel/livepatch/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index af46438..b4b8bb0 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -182,7 +182,10 @@ static int klp_find_object_symbol(const char *objname, const char *name,
};
mutex_lock(&module_mutex);
- kallsyms_on_each_symbol(klp_find_callback, &args);
+ if (objname)
+ module_kallsyms_on_each_symbol(klp_find_callback, &args);
+ else
+ kallsyms_on_each_symbol(klp_find_callback, &args);
mutex_unlock(&module_mutex);
/*
--
1.8.3.1
next reply other threads:[~2017-03-28 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 2:02 Zhou Chengming [this message]
2017-03-28 9:00 ` Miroslav Benes
2017-03-28 10:58 ` zhouchengming
2017-03-28 11:16 ` Miroslav Benes
2017-03-28 12:50 ` zhouchengming
2017-03-29 0:03 ` Jessica Yu
2017-03-29 1:50 ` Li Bin
2017-03-29 19:09 ` Jessica Yu
2017-10-13 12:54 ` Ruslan Bilovol
2017-10-13 13:18 ` Torsten Duwe
2017-10-17 12:44 ` Ruslan Bilovol
2017-10-17 13:06 ` Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490666535-19192-1-git-send-email-zhouchengming1@huawei.com \
--to=zhouchengming1@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®