From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcGUXR2 (ORCPT ); Thu, 21 Jul 2016 19:17:28 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:51189 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751427AbcGUXR1 (ORCPT ); Thu, 21 Jul 2016 19:17:27 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, steve.muckle@linaro.org, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, Juri.Lelli@arm.com, patrick.bellasi@arm.com Subject: Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index() Date: Fri, 22 Jul 2016 01:22:22 +0200 Message-ID: <1490801.bHMYROVPDC@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <065301260510fbca81f5481b27b0de956073068a.1469137133.git.viresh.kumar@linaro.org> References: <065301260510fbca81f5481b27b0de956073068a.1469137133.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 21, 2016 02:39:26 PM Viresh Kumar wrote: > The handlers provided by cpufreq core are sufficient for resolving the > frequency for drivers providing ->target_index(), as the core already > has the frequency table and so ->resolve_freq() isn't required for such > platforms. > > This patch disallows drivers with ->target_index() callback to use the > ->resolve_freq() callback. > > Also, it fixes a potential kernel crash for drivers providing ->target() > but no ->resolve_freq(). > > Fixes: e3c062360870 ("cpufreq: add cpufreq_driver_resolve_freq()") > Signed-off-by: Viresh Kumar OK, applied. Thanks, Rafael