mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Aditya Garg <gargaditya08@live.com>, pmladek@suse.com
Cc: admin@kodeit.net, airlied@redhat.com, akpm@linux-foundation.org,
	 alyssa@rosenzweig.io, andriy.shevchenko@linux.intel.com,
	apw@canonical.com, asahi@lists.linux.dev, corbet@lwn.net,
	dri-devel@lists.freedesktop.org,  dwaipayanray1@gmail.com,
	geert@linux-m68k.org, kees@kernel.org,
	 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux@rasmusvillemoes.dk, lukas.bulwahn@gmail.com,
	marcan@marcan.st,  mripard@kernel.org, rostedt@goodmis.org,
	senozhatsky@chromium.org, simona@ffwll.ch, 	sven@svenpeter.dev,
	tamird@gmail.com, tzimmermann@suse.de
Subject: Re: [PATCH] checkpatch: remove %p4cn
Date: Tue, 29 Apr 2025 10:35:48 -0700	[thread overview]
Message-ID: <1490923bf0b7d5e32ded1393c1f7a3e4e640de5b.camel@perches.com> (raw)
In-Reply-To: <PN3PR01MB95971954FC5E026C59B6F8EDB8802@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

On Tue, 2025-04-29 at 16:07 +0000, Aditya Garg wrote:
> %p4cn was recently removed and replaced by %p4chR in vsprintf. So,
> remove the check for %p4cn from checkpatch.pl.
> 
> Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering")
> 
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 44e233b6f..f79f0a085 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6891,7 +6891,7 @@ sub process {
>  					    ($extension eq "f" &&
>  					     defined $qualifier && $qualifier !~ /^w/) ||
>  					    ($extension eq "4" &&
> -					     defined $qualifier && $qualifier !~ /^c[hnlbc]/)) {
> +					     defined $qualifier && $qualifier !~ /^c[hlbc]/)) {

Probably needs to be something like:

					$qualifier !~ /^c(?:[hlbc]|cR)$/

>  						$bad_specifier = $specifier;
>  						last;
>  					}


  reply	other threads:[~2025-04-29 20:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 12:31 [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering Petr Mladek
2025-04-28 13:02 ` Aditya Garg
2025-04-28 13:33 ` Geert Uytterhoeven
2025-04-28 17:00 ` Alyssa Rosenzweig
2025-04-28 17:08   ` Aditya Garg
2025-04-29 11:39     ` Petr Mladek
2025-04-29 13:27       ` Alyssa Rosenzweig
2025-04-29 13:53 ` Aditya Garg
2025-04-29 13:53 ` Alyssa Rosenzweig
2025-04-29 16:07 ` [PATCH] checkpatch: remove %p4cn Aditya Garg
2025-04-29 17:35   ` Joe Perches [this message]
2025-04-29 17:48     ` Aditya Garg
2025-04-30 13:49   ` [PATCH v3] " Aditya Garg
2025-05-02 13:30     ` Petr Mladek
2025-05-06 15:40     ` Alyssa Rosenzweig
2025-04-29 17:50 ` [PATCH v2] checkpatch: remove %p4cn and add check for %p4chR Aditya Garg
2025-04-30 12:47   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490923bf0b7d5e32ded1393c1f7a3e4e640de5b.camel@perches.com \
    --to=joe@perches.com \
    --cc=admin@kodeit.net \
    --cc=airlied@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alyssa@rosenzweig.io \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apw@canonical.com \
    --cc=asahi@lists.linux.dev \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=geert@linux-m68k.org \
    --cc=kees@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=lukas.bulwahn@gmail.com \
    --cc=marcan@marcan.st \
    --cc=mripard@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=simona@ffwll.ch \
    --cc=sven@svenpeter.dev \
    --cc=tamird@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome