From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751282AbdDCE5b (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Apr 2017 00:57:31 -0400
Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:49174 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751033AbdDCE5a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Apr 2017 00:57:30 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:4321:4605:5007:7514:9149:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: home66_40b330e366d0f
X-Filterd-Recvd-Size: 2657
Message-ID: <1491195442.27353.54.camel@perches.com>
Subject: Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue
From: Joe Perches <joe@perches.com>
To: Prasant Jalan <prasant.jalan@gmail.com>, Larry.Finger@lwfinger.net
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg KH <gregkh@linuxfoundation.org>, geliangtang@163.com,
        raphael.beamonte@gmail.com, vijaikumar.kanagarajan@gmail.com,
        Souptick Joarder <jrdr.linux@gmail.com>,
        driverdevel <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Sun, 02 Apr 2017 21:57:22 -0700
In-Reply-To: <CAOzquK9Mnt5KhBVwko0cJunvfTRWyLhuPj_-8efQjVKMhH0T_A@mail.gmail.com>
References: <1490812390-27905-1-git-send-email-prasant.jalan@gmail.com>
         <CAOzquK9Mnt5KhBVwko0cJunvfTRWyLhuPj_-8efQjVKMhH0T_A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
> > Checkpatch emits WARNING: Avoid multiple line dereference.
> > 
> > Trivial indentation improvement helps fix the checkpatch warning.
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
[]
> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
> >                                                            &pframe[10], 6);
> >                         }
> >                         if (pqospriv->qos_option == 1)
> > -                                       priority[0] = (u8)pxmitframe->
> > -                                                     attrib.priority;
> > +                               priority[0] = (u8)pxmitframe->attrib.priority;
> >                         r8712_secmicappend(&micdata, &priority[0], 4);
> >                         payload = pframe;
> >                         for (curfragnum = 0; curfragnum < pattrib->nr_frags;
> >                              curfragnum++) {
> >                                 payload = (u8 *)RND4((addr_t)(payload));
> > -                               payload = payload + pattrib->
> > -                                         hdrlen + pattrib->iv_len;
> > +                               payload = payload + pattrib->hdrlen +
> > +                                         pattrib->iv_len;

+= would be shorter